Skip to content

Commit 1c8e8f2

Browse files
committed
Fix test isolating
1 parent 0d73b5c commit 1c8e8f2

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

package-lock.json

-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"ember-cli-htmlbars-inline-precompile": "1.0.2",
4848
"ember-cli-inject-live-reload": "1.7.0",
4949
"ember-cli-pretender": "1.0.1",
50-
"ember-cli-qunit": "4.3.2",
50+
"ember-qunit": "3.4.0",
5151
"ember-cli-release": "1.0.0-beta.2",
5252
"ember-cli-sass": "7.1.7",
5353
"ember-cli-shims": "1.2.0",

tests/test-helper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ import { start } from 'ember-qunit';
55

66
setApplication(Application.create(config.APP));
77

8-
start();
8+
start({ setupTestIsolationValidation: true });

tests/unit/models/post-test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ test('resource action pushes to store', function(assert) {
166166
});
167167
});
168168

169-
test('responseTypes', function(assert) {
169+
test('responseTypes', async function(assert) {
170170
assert.expect(6);
171171

172172
this.server.post('/posts/list', (request) => {
@@ -177,9 +177,9 @@ test('responseTypes', function(assert) {
177177

178178
let model = this.subject();
179179

180-
let promise = model.list();
181-
let promiseArray = model.list(null, { responseType: 'array' });
182-
let promiseObject = model.list(null, { responseType: 'object' });
180+
let promise; await (promise = model.list());
181+
let promiseArray; await (promiseArray = model.list(null, { responseType: 'array' }));
182+
let promiseObject; await (promiseObject = model.list(null, { responseType: 'object' }));
183183

184184
assert.equal(promise.constructor, RSVP.Promise);
185185
assert.equal(promiseArray.constructor.superclass, ArrayProxy);

0 commit comments

Comments
 (0)