refactor(banners): simplifying dismissAt logic

Author: stackchain

packages/banners/src/banners-manager.test.ts

@@ -53,7 +53,7 @@ describe('bannersManagerMaker', () => {
     const result = manager.dismissedAt(bannerId)
 
     expect(result).toBe(mockDate)
-    expect(storage.getItem).toHaveBeenCalledWith(bannerId, expect.any(Function))
+    expect(storage.getItem).toHaveBeenCalledWith(bannerId)
   })
 
   it('should return 0 if banner is not dismissed', () => {
@@ -65,6 +65,6 @@ describe('bannersManagerMaker', () => {
     const result = manager.dismissedAt(bannerId)
 
     expect(result).toBe(0)
-    expect(storage.getItem).toHaveBeenCalledWith(bannerId, expect.any(Function))
+    expect(storage.getItem).toHaveBeenCalledWith(bannerId)
   })
 })

packages/banners/src/banners-manager.ts

@@ -8,7 +8,9 @@ export const bannersManagerMaker = <K extends string = string>({
   const dismiss = (id: K) =>
     storage.setItem(id, new Date().getTime().toString())
 
-  const dismissedAt = (id: K) => storage.getItem(id, toNumber) ?? 0
+  const dismissedAt = (id: K) => {
+    return toNumber(storage.getItem(id))
+  }
 
   return freeze({dismiss, dismissedAt})
 }