fix(wallet-mobile): Fix address path for message signing and TX review message parsing

[michaeljscript]

Description / Change(s) / Related issue(s)

Fix address path for message signing and TX review message parsing

Ticket

YV-245

[stackchain]

I think is misleading, maybe make it more declarative, -> if Array.isArray ..., first, and then fall back to string, cuz [].join still works, unless is needed to check if it is an array and there is at least 1 element.

[michaeljscript]

Yes, it seems that there are different rules when the length is 1 and when the length is > 1. I'll do a small refactor and ping you to check again if it looks better. It may be good to hear @banklesss thoughts

[stackchain]

maybe something like const string2sign = Array.isArray(msg) ? msg.join() : msg, states clear that signing expects a string only

[michaeljscript]

Note this is not used for signing, just displaying on the TX review screen

[michaeljscript]

I've changed it to the following

const messageToParse = Array.isArray(msg) ? msg.join('') : msg

  try {
    return JSON.parse(messageToParse)
  } catch {
    return messageToParse
  }

[stackchain]

@michaeljscript -> I know what is bugging me, the return type can be whatever, --> JSON.parse('1') = number not string, maybe parse, and then stringify after? :dunno:

[michaeljscript]

Yeah good point

[michaeljscript]

const parsed = JSON.parse(messageToParse)
if (isString(parsed)) return parsed
return JSON.stringify(parsed)