Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet-mobile): drop disable status for action buttons #3846

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

stackchain
Copy link
Member

Description / Change(s) / Related issue(s)

Ticket

YV-260

@@ -22,7 +22,7 @@ import {useSelectedWallet} from '../../../WalletManager/common/hooks/useSelected
import {useWalletManager} from '../../../WalletManager/context/WalletManagerProvider'
import {useStrings} from '../../common/strings'

export const ActionsBanner = ({disabled = false}: {disabled: boolean}) => {
export const ActionsBanner = () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled was added for the first load, since now it doesnt open the wallet before a proper sync (exception for dev build), it is no longer needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened with the check for pool transition?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it part of tx loading state?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two things here, 1st possible a clash with another modal if the user open whatever right after loading the UI, but this would happen anyway if any other action has a modal, 2nd all pools were already migrated, so no worries (for now), the 1st issue will be solved only after building a queue for the modal.

@stackchain stackchain marked this pull request as ready for review February 24, 2025 09:18
@stackchain stackchain force-pushed the chore/drop-action-bar-disabled branch from 0b8da3c to b5e7188 Compare February 24, 2025 09:43
@stackchain stackchain force-pushed the chore/drop-action-bar-disabled branch from 1ab7b26 to 3496ff2 Compare February 24, 2025 10:02
Copy link

codecov bot commented Feb 24, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@stackchain stackchain merged commit adb0db8 into develop Feb 24, 2025
20 of 22 checks passed
@stackchain stackchain deleted the chore/drop-action-bar-disabled branch February 24, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants