Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(banners): banners package #3862

Merged
merged 13 commits into from
Mar 12, 2025
Merged

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Mar 11, 2025

Description / Change(s) / Related issue(s)

Ticket

YV-284

@stackchain stackchain changed the title refactor(banners): lift up show responsability feature(banners): adding banners package Mar 11, 2025
@stackchain stackchain changed the title feature(banners): adding banners package feature(banners): banners package Mar 11, 2025
@stackchain stackchain self-assigned this Mar 11, 2025
@stackchain stackchain modified the milestones: 5.3.0, 5.3.1 Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 32 lines in your changes missing coverage. Please review.

Project coverage is 22.80%. Comparing base (1f2788f) to head (a55516c).

❌ Your project check has failed because the head coverage (22.80%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3862      +/-   ##
===========================================
+ Coverage    22.73%   22.80%   +0.07%     
===========================================
  Files         1156     1163       +7     
  Lines        22074    22125      +51     
  Branches      3405     3409       +4     
===========================================
+ Hits          5018     5046      +28     
- Misses       16911    16934      +23     
  Partials       145      145              
Components Coverage Δ
@yoroi/api 100.00% <ø> (ø)
@yoroi/blockchains 100.00% <ø> (ø)
@yoroi/claim 100.00% <ø> (ø)
@yoroi/common 100.00% <100.00%> (ø)
@yoroi/dapp-connector 100.00% <ø> (ø)
@yoroi/exchange 100.00% <ø> (ø)
@yoroi/explorers 100.00% <ø> (ø)
@yoroi/identicon 100.00% <ø> (ø)
@yoroi/links 100.00% <ø> (ø)
@yoroi/notifications 100.00% <ø> (ø)
@yoroi/portfolio 100.00% <ø> (ø)
@yoroi/resolver 100.00% <ø> (ø)
@yoroi/setup-wallet 100.00% <ø> (ø)
@yoroi/staking 68.82% <ø> (ø)
@yoroi/swap 100.00% <ø> (ø)
@yoroi/theme 100.00% <ø> (ø)
@yoroi/transfer 100.00% <ø> (ø)
@yoroi/types ∅ <ø> (∅)
@yoroi/wallet-mobile 9.48% <13.51%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -77,3 +77,6 @@ export const time = freeze({
// session here means while the wallet is open
session: Infinity,
})

// NOTE: bech32 'drep1ygr9tuapcanc3kpeyy4dc3vmrz9cfe5q7v9wj3x9j0ap3tswtre9j'
export const yoroiDRepIdHex = '220655f3a1c76788d839212adc459b188b84e680f30ae944c593fa18ae'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljscript the endpoint is returning the hash of the vote drep delegation.

@@ -153,15 +153,9 @@ PODS:
- libwebp/sharpyuv (1.3.2)
- libwebp/webp (1.3.2):
- libwebp/sharpyuv
<<<<<<< Updated upstream
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stackchain stackchain marked this pull request as ready for review March 12, 2025 08:32
@stackchain stackchain merged commit d70cdbf into develop Mar 12, 2025
1 check passed
@stackchain stackchain deleted the feature/YV-284/staking-banners branch March 12, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants