feat(wallet-mobile): Add delegate to Yoroi banners #3863
+2,166
−536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3863 +/- ##
===========================================
+ Coverage 22.80% 22.87% +0.06%
===========================================
Files 1163 1168 +5
Lines 22125 22168 +43
Branches 3409 3410 +1
===========================================
+ Hits 5046 5071 +25
- Misses 16934 16952 +18
Partials 145 145
🚀 New features to boost your workflow:
|
jorbuedo
approved these changes
Mar 11, 2025
|
Let me fix it |
banklesss
approved these changes
Mar 12, 2025
stackchain
force-pushed
the
feat/delegation-banner
branch
from
b164c3f to
4f989ba
Compare
|
stackchain
changed the title
stackchain
reviewed
Mar 13, 2025
| @@ -38,7 +40,7 @@ export const ConsiderDRepToUsTxHistoryBanner = () => { | |||
| isStaking: hasStakingKeyRegistered, | |||
| dismissedAt, | |||
| ptBalance: balance.quantity, | |||
| ptMinBalance: 5n * BigInt(ptDecimals), | |||
| ptMinBalance: BigInt(minBalanceToDisplayBanner) * BigInt(ptDecimals), | |||
There was a problem hiding this comment.
Suggested change
| ptMinBalance: BigInt(minBalanceToDisplayBanner) * BigInt(ptDecimals), | |
| ptMinBalance: BigInt(minBalanceToDisplayBanner) * BigInt(10n ** ptDecimals), |
stackchain
reviewed
Mar 13, 2025
| ptBalance: 0n, | ||
| ptMinBalance: 0n, | ||
| ptBalance: balance.quantity, | ||
| ptMinBalance: 5n * BigInt(ptDecimals), |
There was a problem hiding this comment.
Suggested change
| ptMinBalance: 5n * BigInt(ptDecimals), | |
| ptMinBalance: BigInt(minBalanceToDisplayBanner) * BigInt(10n ** ptDecimals), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Create governance Yoroi delegation banner
Ticket
YV-292