Fixed test cases involving ranks schema change.

Author: justin-b-yee

app/socket-apis/__tests__/get-top-ranked-whys-for-point.js

@@ -87,6 +87,10 @@ describe('getTopRankedWhysForPoint', () => {
           _id: new ObjectId(),
           parentId: why._id.toString(),
           userId: USER1,
+          round: why.round,
+          stage: 'pre',
+          category: why.category,
+          discussionId: 'discussion-1',
         })
       }
     })
@@ -117,6 +121,10 @@ describe('getTopRankedWhysForPoint', () => {
           _id: new ObjectId(),
           parentId: why._id.toString(),
           userId: USER1,
+          round: why.round,
+          stage: 'pre',
+          category: why.category,
+          discussionId: 'discussion-1',
         })
       }
     })
@@ -147,6 +155,10 @@ describe('getTopRankedWhysForPoint', () => {
           _id: new ObjectId(),
           parentId: why._id.toString(),
           userId: USER1,
+          round: why.round,
+          stage: 'pre',
+          category: why.category,
+          discussionId: 'discussion-1',
         })
       }
     })
@@ -177,6 +189,10 @@ describe('getTopRankedWhysForPoint', () => {
           _id: new ObjectId(),
           parentId: why._id.toString(),
           userId: USER1,
+          round: why.round,
+          stage: 'pre',
+          category: why.category,
+          discussionId: 'discussion-1',
         })
       }
     })
@@ -207,6 +223,10 @@ describe('getTopRankedWhysForPoint', () => {
           _id: new ObjectId(),
           parentId: why._id.toString(),
           userId: USER1,
+          round: why.round,
+          stage: 'pre',
+          category: why.category,
+          discussionId: 'discussion-1',
         })
       }
     })

app/socket-apis/__tests__/rank-why.js

@@ -21,29 +21,62 @@ beforeEach(async () => {
   for (let collection of collections) {
     await collection.deleteMany({})
   }
+
+  jest.spyOn(console, 'error').mockImplementation(() => {})
+})
+
+afterEach(async () => {
+  console.error.mockRestore()
 })
+
 afterAll(async () => {
   await Mongo.disconnect()
   await MemoryServer.stop()
 })
 
 test('Insert a new rank document', async () => {
-  const rankObj = { _id: RANK2, parentId: 'parent-id-1', round: 1, rank: 'most' }
+  const rankObj = {
+    _id: RANK2,
+    parentId: 'parent-id-1',
+    round: 1,
+    rank: 'most',
+    stage: 'pre',
+    category: 'category-1',
+    discussionId: 'discussion-1',
+  }
 
   const cb = jest.fn()
 
   await rankWhy.call({ synuser: { id: USER1 } }, rankObj, cb)
 
   expect(cb).toHaveBeenCalledTimes(1)
+
   const rank = await Mongo.db.collection('ranks').findOne({ parentId: 'parent-id-1', userId: USER1 })
   expect(rank).toEqual({ ...rankObj, userId: USER1 })
 })
 
 test('Update an existing rank document with a different rank', async () => {
-  const existingRank = { _id: RANK1, parentId: 'parent-id-1', userId: USER1, round: 1, rank: 'most' }
+  const existingRank = {
+    _id: RANK1,
+    parentId: 'parent-id-1',
+    userId: USER1,
+    round: 1,
+    rank: 'most',
+    stage: 'pre',
+    category: 'category-1',
+    discussionId: 'discussion-1',
+  }
   await Mongo.db.collection('ranks').insertOne(existingRank)
 
-  const updatedRankObj = { _id: RANK1, parentId: 'parent-id-1', round: 1, rank: 'least' }
+  const updatedRankObj = {
+    _id: RANK1,
+    parentId: 'parent-id-1',
+    round: 1,
+    rank: 'least',
+    stage: 'pre',
+    category: 'category-1',
+    discussionId: 'discussion-1',
+  }
 
   const cb = jest.fn()
 

app/socket-apis/rank-why.js

@@ -4,7 +4,7 @@ const Ranks = require('../models/ranks')
 
 async function validateRankObj(rankObj) {
   // Basic validation to check required fields
-  if (!rankObj.parentId || !rankObj.round || !rankObj.rank) {
+  if (!rankObj.parentId || !rankObj.round || !rankObj.rank || !rankObj.discussionId || !rankObj.stage) {
     console.log('Validation result: not valid')
     return false
   }