TopNavBar adjustments #183 #275
Conversation
agrawalashita
commented
Jan 18, 2025
agrawalashita
commented
- Fixed vertical alignment of the props and logo
- Adjusted Donate button alignment in mobile view
There was a problem hiding this comment.
The alignment looks good.
In the Dark Mode Mobile case there is:
The donate button should be on the bottom not on the side.
You can easily switch back to master with storybook running and see the difference.
Also, I am going to add a couple of issues to this issue that are problem I see, not with your changes but with previous changes that weren't detected.
|
I have fixed the donate button issue @ddfridley. The new issues which you have added in issue #183, should that be fixed as part of this PR? |
|
Yes, please fix them too. They are existing bugs but since they are in this same code and really need to be fixed, we should keep our attention on it. But if it becomes too difficult, we can separate them out into another issue. |
|
@agrawalashita Are you able to address these 2 tasks I had added to the issue?
|
