Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

207 api getwhyranksandpointsdiscussionidround mostids leastids cb ranks points #245

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

207 api getwhyranksandpointsdiscussionidround mostids leastids cb ranks points #245

wants to merge 8 commits into from

Conversation

ldgze
Copy link
Contributor

@ldgze ldgze commented Nov 11, 2024

No description provided.

@ldgze ldgze linked an issue Nov 11, 2024 that may be closed by this pull request
api getWhyRanksAndPoints(discussionId,round, mostIds, leastIds, cb( {ranks: [], points: [] }) #207
Open
7 tasks
@ldgze ldgze mentioned this pull request Nov 15, 2024
Open
7 tasks
ddfridley
ddfridley requested changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@ddfridley ddfridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I appreciate the use of Promises.all() see inline comments.

@ldgze ldgze marked this pull request as ready for review November 24, 2024 20:53
ddfridley
ddfridley requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ddfridley ddfridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I npm run test get-why-ranks-and-points I see this failing 3 tests:

Test Suites: 1 failed, 1 total                                                                                                                                                                                                                                                                                            
Tests:       3 failed, 2 passed, 5 total                                                                                                                                                                                                                                                                                  
Snapshots:   0 total
Time:        12.737 s

On think I see is the difference between whys: undefined and whys: [], whys should be undefined if data hasn't been fetched from the db yet. But mostly with this api, whatever it returns is after the fetch, so it should return whys: [].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddfridley ddfridley ddfridley requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api getWhyRanksAndPoints(discussionId,round, mostIds, leastIds, cb( {ranks: [], points: [] })
2 participants
@ldgze @ddfridley