Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dturn prop validation #240

Open
8 tasks
ddfridley opened this issue Nov 4, 2024 · 2 comments · May be fixed by #281
Open
8 tasks

Dturn prop validation #240

ddfridley opened this issue Nov 4, 2024 · 2 comments · May be fixed by #281
Assignees

Comments

@ddfridley
Copy link
Contributor

ddfridley commented Nov 4, 2024

in app/dturn/dturn.js

These functions need to validate their props:

  • common:
  • discussionId exists in Discussions
  • round must be between 0 and lastRound+1
  • insertStatementId
  • round must be 0 (for now)
  • getStatementIds
  • userId must be part of the discussion
  • putGroupings
  • for the round, user must have been shown the statementIds in statementIds
  • rankMostImportant
  • for the round, user must have been shown the statementId
  • rank must be 0 or 1
  • Tests
  • Create jest tests in app/dturn/tests

Discussions[discussionId].Uitems[userId][round] can be used to figure out if a user has been shown statementIds

@ddfridley ddfridley changed the title rankMostImportant validate args Dturn prop validation Nov 25, 2024
@guodong323
Copy link
Contributor

I interested in this issue. Please assign it to me.

@ddfridley
Copy link
Contributor Author

ddfridley commented Jan 20, 2025 via email

@guodong323 guodong323 self-assigned this Jan 20, 2025
@ddfridley ddfridley moved this from Todo to In Progress in EnCiv Cross Repo Project Management Jan 20, 2025
@guodong323 guodong323 moved this from In Progress to Ready for Review in EnCiv Cross Repo Project Management Feb 1, 2025
@ddfridley ddfridley linked a pull request Feb 3, 2025 that will close this issue
@ddfridley ddfridley moved this from Ready for Review to In Progress in EnCiv Cross Repo Project Management Feb 3, 2025
@guodong323 guodong323 moved this from In Progress to Ready for Review in EnCiv Cross Repo Project Management Feb 15, 2025
@ddfridley ddfridley moved this from Ready for Review to In Progress in EnCiv Cross Repo Project Management Feb 21, 2025
@guodong323 guodong323 moved this from In Progress to Ready for Review in EnCiv Cross Repo Project Management Feb 24, 2025
@ddfridley ddfridley moved this from Ready for Review to In Progress in EnCiv Cross Repo Project Management Feb 26, 2025
@guodong323 guodong323 moved this from In Progress to Ready for Review in EnCiv Cross Repo Project Management Mar 17, 2025
@ddfridley ddfridley moved this from Ready for Review to In Progress in EnCiv Cross Repo Project Management Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants