Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the text message in Login Page #241

Open
Saimurugeshwari opened this issue Feb 24, 2024 · 11 comments
Open

Changing the text message in Login Page #241

Saimurugeshwari opened this issue Feb 24, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Saimurugeshwari
Copy link
Collaborator

Step to Reproduce:

1:Click Login
2:Enter your email id and click Send Reset Password
3:the txt will display " Message Send " instead of Email Send" Hence please change the text: Email Send, please check your Inbox!

Suggestion:

Change from "Send Reset Password to Forget Password:

Screen Shot:
Screenshot 2024-02-24 142653

@Saimurugeshwari Saimurugeshwari added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 24, 2024
@MohitKambli
Copy link

Hello @Saimurugeshwari,
Hope you're doing well.
I would like to work on this issue.

Thanks and Regards,
Mohit Kambli

@Saimurugeshwari
Copy link
Collaborator Author

@MohitKambli Go ahead, kindly raise a PR request once you done, Thank you.

@ddfridley
Copy link
Contributor

ddfridley commented Feb 25, 2024 via email

@MohitKambli
Copy link

Hello @Saimurugeshwari,
Hope you're doing well.
So, regarding the suggestion that you have mentioned:
Change from "Send Reset Password" to "Forget Password"
This code change can be done since this message resides within the undebate-ssp repository.
The changes for the same can be done in app/components/signin-signup.js as follows:

<div className={cx(classes.resetPasswordBtn, !isLogIn && classes.disabled)}>
    <button onClick={e => methods.sendResetPassword()} className={classes.resetBtn}>
        Forgot Password
    </button>
</div>

image

However, if we consider the text message once the user clicks the forgot password button, this message actually comes from another repository altogether, called civil-client.
To be specific, the message is most probably coming from here.
So, I guess the change from Message Sent to Email Sent should be either done in the above file mentioned or maybe the message should be displayed here:

<div>
    {state.error && <div style={{ color: '#fec215', textAlign: 'center' }}>{state.error}</div>}
    {state.info && <div style={{ color: '#fec215', textAlign: 'center' }}>{state.info}</div>}
    {state.success && <div style={{ color: '#fec215', textAlign: 'center' }}>{state.success}</div>}
</div>

image

Instead of state.success, we can display 'Message sent! Please check your inbox'.
By making the above change, the required message would get displayed, but what exactly should we do in this case?
I hope you understand my point.

If at all there is any incorrect information coming from my end, then do let me know.
Sincere apologies for making any mistakes if I mentioned any.

Thanks and Regards,
Mohit Kambli

@ddfridley
Copy link
Contributor

@MohitKambli I have invited you to the EnCiv/developers team. Through that you will be able to access civil-pursuit, civil-client, and civil-server. Also have you would like to join the slack work space, please fill out this form and it will give you the url to join slack. https://docs.google.com/forms/d/e/1FAIpQLSee58BUiy12dtloG9pLITsELcNldIwXcEtCotV9r95BZJSIVA/viewform?usp=sf_link

@ddfridley
Copy link
Contributor

@MohitKambli Also, can you take a look at this issue: #238 I am not able to recreate it on my pc, running edge or chrome. At 100% zoom, the signup page is in the window. What do you see? Thanks.

@MohitKambli
Copy link

MohitKambli commented Feb 26, 2024

Hello @ddfridley,
Hope you're doing well.
The thing is, I am trying to bring up the server on my machine locally, but the very first step of npm install is taking a lot of time (~25-30 mins) to execute and eventually it fails, which looks like this:

image

Since this command took decent amount of time, while it was getting executed, I thought of going through the code and try to fix the errors, which is why I am able to get the required code changes, but not able to actually implement it on the web application.
I am trying to start up the server locally.
I just hope it comes up soon.
Sincere apologies for not being able to help much due to such situation.
Once I am able to bring the server up locally, I will definitely come back and update about the same.
If you have anything that I can try to fix this problem, then do let me know.
I am deeply sorry if I am making any mistakes here or implementing something incorrectly.

Thanks and Regards,
Mohit Kambli

@ddfridley
Copy link
Contributor

ddfridley commented Feb 26, 2024 via email

@ddfridley
Copy link
Contributor

ddfridley commented Feb 26, 2024 via email

@MohitKambli
Copy link

Hello @ddfridley,
Hope you're doing well.
As you have mentioned in the comment and in the README file, I have configured the following on my machine:

PS D:\Programming\JavaScript\OpenSourceContributions\undebate-ssp> node --version
v16.16.0
PS D:\Programming\JavaScript\OpenSourceContributions\undebate-ssp> npm -v
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
8.13.2

After configuring these, I fired the npm ci command to remove and rebuild the node_modules directory.
But after doing so, I am getting the following error stack trace:

image

I don't know what mistake am I doing.
Due to this, I am not able to bring the server up:

image

If at all you have any leads regarding this error trace, then do let me know.
Sincere apologies for the trouble being caused.

Thanks and Regards,
Mohit Kambli

@ddfridley
Copy link
Contributor

@MohitKambli Did we ever resolve this? In the above screen the terminal is Powershell. For this project bash is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants