Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Matthieu Barba <mbarba@ebi.ac.uk>
  • Loading branch information
JAlvarezJarreta and MatBarba authored Mar 22, 2024
1 parent f998b95 commit c04368f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/python/tests/database/test_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ def _get_meta_value(meta_key: str) -> Optional[str]:
mock_dbconn.return_value = dbconnection

result = factory.format_db_data(server_url, dbs, brc_mode)
print(result)
assert not DeepDiff(result, output)
if dbs:
calls = [call("species.production_name"), call("species.division"), call("assembly.accession")]
Expand Down Expand Up @@ -182,9 +181,9 @@ def test_get_core_dbs_metadata(
output: Expected list of dictionaries with some metadata for each selected database.
"""

# pylint: disable=unused-argument
def _format_db_data(server_url: URL, dbs: List[str], brc_mode: bool = False) -> List[Dict]:
"""Returns metadata from a list of databases."""
_ = (server_url, brc_mode) # Unused by mock
return [{"database": db, "species": "dog"} for db in dbs]

if use_db_file:
Expand Down

0 comments on commit c04368f

Please sign in to comment.