-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for ensembl.io.genomio.genome_metadata.dump module #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some questions about the code
@MatBarba asked for a re-review due to the addition of updated and unit test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. At some point we might want to test with test databases, but that part is pretty "simple" so the testing is clear.
Updated all methods (review docstrings, improve readability and reduce code complexity) and added unit tests for all of them.
In the case of
get_genome_metadata()
the rework whilst may not be as efficient as the previous code, I believe it is more readable and allows for further meta table checks in case the data found there does not match the expected format, e.g. isspecies
meta key always has a subkey but there is an entry without, aValueError
is raised.Added to
__all__
one of the functions that was missing.