Skip to content

Commit 127a31d

Browse files
committed
refactor: rename footerExcludeList to webviewRoutes for clarity; update related logic in App.vue; remove shadow effect from buttons in External, Kick, and Twitch components
1 parent 30a192d commit 127a31d

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

src/App.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const notifications = shallowRef({
3333
showToggleUnbound: false,
3434
});
3535
36-
const footerExcludeList: typeof route.name[] = ['/webview/twitch', '/webview/externalsource', '/webview/kick', '/versioncheck'];
36+
const webviewRoutes: typeof route.name[] = ['/webview/twitch', '/webview/externalsource', '/webview/kick', '/versioncheck'];
3737
3838
const $html = document.querySelector('html');
3939
const $app = document.querySelector('#app');
@@ -59,7 +59,7 @@ onMounted(async () => {
5959
});
6060
6161
watch(route, () => {
62-
showFooter.value = !footerExcludeList.includes(route.name) && !route.path.startsWith('/settings');
62+
showFooter.value = !webviewRoutes.includes(route.name) && !route.path.startsWith('/settings');
6363
showMenuBar.value = !(route.path.startsWith('/settings') || route.name === '/versioncheck');
6464
additionalFooterClasses.value = route.name === '/changelog'
6565
? {
@@ -111,8 +111,8 @@ ipcRenderer.on(IpcEvent.Notification, (_, notification) => {
111111
<template>
112112
<div :key="rerenderKey" class="grid min-h-dvh grid-rows-[auto_1fr_auto]">
113113
<header
114-
v-if="showMenuBar" class="flex w-full justify-between align-top"
115-
:class="footerExcludeList.includes(route.name) ? 'absolute' : 'sticky'"
114+
v-if="showMenuBar" class="flex w-full justify-between"
115+
:class="webviewRoutes.includes(route.name) ? 'absolute' : ''"
116116
>
117117
<DropDownMenu />
118118
<MenuButtons />

src/components/index/External.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ function applySourceFromList(item: string) {
6868
<template>
6969
<Dialog>
7070
<DialogTrigger>
71-
<div class="flex justify-center rounded bg-secondary p-4 shadow-xl hover:scale-105 hover:cursor-pointer">
71+
<div class="flex justify-center rounded bg-secondary p-4 hover:scale-105 hover:cursor-pointer">
7272
<Icon icon="pepicons-print:internet" class="h-12 w-10 text-blue-500" />
7373
</div>
7474
</DialogTrigger>

src/components/index/Kick.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ async function routeChat() {
4141
<template>
4242
<Dialog>
4343
<DialogTrigger>
44-
<div class="flex justify-center rounded bg-secondary p-4 shadow-xl hover:scale-105 hover:cursor-pointer">
44+
<div class="flex justify-center rounded bg-secondary p-4 hover:scale-105 hover:cursor-pointer">
4545
<img src="../../assets/brands/kick.png" class="h-12" alt="kick">
4646
</div>
4747
</DialogTrigger>

src/components/index/Twitch.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ async function routeChat() {
4141
<template>
4242
<Dialog>
4343
<DialogTrigger>
44-
<div class="flex justify-center rounded bg-secondary p-4 shadow-xl hover:scale-105 hover:cursor-pointer">
44+
<div class="flex justify-center rounded bg-secondary p-4 hover:scale-105 hover:cursor-pointer">
4545
<img src="../../assets/brands/twitch.png" class="h-12" alt="twitch">
4646
</div>
4747
</DialogTrigger>

src/pages/index.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ import Twitch from '#components/index/Twitch.vue';
55
</script>
66

77
<template>
8-
<div class="my-12 grid grid-cols-1 items-center justify-center gap-2 px-10 sm:grid-cols-2">
8+
<div class="grid h-full grid-rows-4 px-10">
99
<Twitch />
1010
<Kick />
1111
<External />
12+
<!-- placeholder for youtube -->
13+
<External />
1214
</div>
1315
</template>

0 commit comments

Comments
 (0)