Correct last address in examples

Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>

Author: SRGDamia1

ChangeLog.md

@@ -32,7 +32,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 - **Breaking** Changed the `parseInt()`, `parseFloat()`, and `peekNextDigit()` functions so that they are better customized for reading from a data response request.
   - Any LookupMode or ignore inputs will be ignored.
-- **Potentially Breaking** Parity checking can no longer be turned off. Characters that fail parity checks will no be returned from the buffer.
+- **Potentially Breaking** Parity checking can no longer be turned off. Characters that fail parity checks will not be returned from the buffer.
 - Change fudge for 48MHz boards using millis() from 50 to 95 based on comments in [#145](https://github.com/EnviroDIY/Arduino-SDI-12/issues/145)
 - Reset bit timer when entering listening state.
 - Verify that at least one bit time has passed before processing a pin change interrupt, where possible.

README.md

@@ -80,7 +80,7 @@ The pre-scaler values needed for the SDI-12 functionality are set in the begin()
 ## Compatibility Considerations<!-- {#mainpage_compatibility} -->
 
 This library has been tested with an Arduino Uno (AtMega328p), EnviroDIY Mayfly (AtMega1284p), Adafruit Feather 32u4 (AtMega32u4, identical to Arduino Leonardo), an Adafruit Feather M0 (SAMD21G18, identical to Arduino Zero), the ESP8266, and the ESP32.
-It should also work on an Arduino Mega (AtMega2560), Gemma/AtTiny board, and most other AVR processors  running on the Arduino framework.
+It should also work on an Arduino Mega (AtMega2560), Gemma/AtTiny board, and most other AVR processors running on the Arduino framework.
 
 The Arduino Due, Arduino 101, and Teensy boards are not supported at this time.
 If you are interested in adding support for those boards, please send pull requests.

examples/c_check_all_addresses/c_check_all_addresses.ino

@@ -34,7 +34,7 @@ uint32_t wake_delay   = 0; /*!< Extra time needed for the sensor to wake (0-100m
 int8_t   firstPin     = 3; /*! change to lowest pin number to search on your board */
 int8_t   lastPin      = 7; /*! change to highest pin number to search on your board */
 int8_t   firstAddress = 0; /* The first address in the address space to check (0='0') */
-int8_t   lastAddress  = 9; /* The last address in the address space to check (62='z') */
+int8_t   lastAddress = 61; /* The last address in the address space to check (61='z') */
 
 /**
  * @brief converts allowable address characters ('0'-'9', 'a'-'z', 'A'-'Z') to a
@@ -128,8 +128,8 @@ void scanAddressSpace(SDI12& sdi) {
     char addr = decToChar(i);
     Serial.print("i=");
     Serial.print(i);
-    Serial.print("addr=");
-    Serial.print(addr);
+    Serial.print(" addr=");
+    Serial.println(addr);
     if (checkActive(sdi, addr)) { printInfo(sdi, addr); };
   }
 }

examples/d_simple_logger/d_simple_logger.ino

@@ -38,7 +38,7 @@ int8_t   dataPin      = SDI12_DATA_PIN; /*!< The pin of the SDI-12 data bus */
 int8_t   powerPin     = SDI12_POWER_PIN; /*!< The sensor power pin (or -1) */
 uint32_t wake_delay   = 0; /*!< Extra time needed for the sensor to wake (0-100ms) */
 int8_t   firstAddress = 0; /* The first address in the address space to check (0='0') */
-int8_t   lastAddress = 62; /* The last address in the address space to check (62='z') */
+int8_t   lastAddress = 61; /* The last address in the address space to check (61='z') */
 bool     printIO     = false;
 
 /** Define the SDI-12 bus */

examples/e_continuous_measurement/e_continuous_measurement.ino

@@ -28,7 +28,7 @@ int8_t   dataPin      = SDI12_DATA_PIN; /*!< The pin of the SDI-12 data bus */
 int8_t   powerPin     = SDI12_POWER_PIN; /*!< The sensor power pin (or -1) */
 uint32_t wake_delay   = 0; /*!< Extra time needed for the sensor to wake (0-100ms) */
 int8_t   firstAddress = 0; /* The first address in the address space to check (0='0') */
-int8_t   lastAddress = 62; /* The last address in the address space to check (62='z') */
+int8_t   lastAddress = 61; /* The last address in the address space to check (61='z') */
 bool     printIO     = false;
 
 /** Define the SDI-12 bus */

examples/j_external_pcint_library/j_external_pcint_library.ino

@@ -31,7 +31,7 @@ int8_t   dataPin      = SDI12_DATA_PIN; /*!< The pin of the SDI-12 data bus */
 int8_t   powerPin     = SDI12_POWER_PIN; /*!< The sensor power pin (or -1) */
 uint32_t wake_delay   = 0; /*!< Extra time needed for the sensor to wake (0-100ms) */
 int8_t   firstAddress = 0; /* The first address in the address space to check (0='0') */
-int8_t   lastAddress = 62; /* The last address in the address space to check (62='z') */
+int8_t   lastAddress = 61; /* The last address in the address space to check (61='z') */
 bool     printIO     = false;
 
 /** Define the SDI-12 bus */

examples/k_concurrent_logger/k_concurrent_logger.ino

@@ -28,7 +28,7 @@ int8_t   dataPin      = SDI12_DATA_PIN; /*!< The pin of the SDI-12 data bus */
 int8_t   powerPin     = SDI12_POWER_PIN; /*!< The sensor power pin (or -1) */
 uint32_t wake_delay   = 0; /*!< Extra time needed for the sensor to wake (0-100ms) */
 int8_t   firstAddress = 0; /* The first address in the address space to check (0='0') */
-int8_t   lastAddress = 62; /* The last address in the address space to check (62='z') */
+int8_t   lastAddress = 61; /* The last address in the address space to check (61='z') */
 bool     printIO     = false;
 
 /** Define the SDI-12 bus */

extras/TestCommands/TestCommands.ino

@@ -26,7 +26,7 @@ uint32_t     wake_delay = 10; /*!< Extra time needed for the sensor to wake (0-1
 const int8_t firstAddress =
   0; /* The first address in the address space to check (0='0') */
 const int8_t lastAddress =
-  62; /* The last address in the address space to check (62='z') */
+  61; /* The last address in the address space to check (61='z') */
 const int8_t commandsToTest =
   1; /*!< The number of measurement commands to test, between 1 and 11. */
 
@@ -363,19 +363,21 @@ getResultsResult getResults(char addr, int resultsExpected, bool verify_crc = fa
         // NOTE: A mis-read like this should also cause the CRC to be wrong, but still
         // check here in case we're not using a CRC.
       } else {  //(c != '-' && c != '+' && (c < '0' || c > '9') && c != '.')
-        Serial.println("Invalid data response character!");
+        Serial.print("Invalid data response character: ");
+        Serial.write(c);
+        Serial.println();
         bad_read = true;
       }
       // if we get a decimal, mark it so we can verify we don't get repeated decimals
       if (c == '.') { got_decimal = true; }
     }
 
-    if (!gotResults) {
-      if (printIO) {
-        Serial.println(("  No results received, will not continue requests!"));
-      }
-      break;
-    }  // don't do another loop if we got nothing
+    // if (!gotResults) {
+    //   if (printIO) {
+    //     Serial.println(("  No results received, will not continue requests!"));
+    //   }
+    //   break;
+    // }  // don't do another loop if we got nothing
 
     if (gotResults && !bad_read) {
       resultsReceived = resultsReceived + cmd_results;
@@ -640,7 +642,7 @@ bool checkActive(char addr, int8_t numPings = 3, bool printIO = true) {
       Serial.println(")");
       if (returnedAddress == String(addr)) {
         if (printIO) {
-          Serial.println("Got response from '");
+          Serial.print("Got response from '");
           Serial.print(String(returnedAddress));
           Serial.println("'");
         }
@@ -665,9 +667,13 @@ bool checkActive(char addr, int8_t numPings = 3, bool printIO = true) {
 void setup() {
   Serial.begin(serialBaud);
   while (!Serial && millis() < 10000L);
+  char tbuf[3] = {'\0'};
 
   Serial.print("Opening SDI-12 bus on pin ");
-  Serial.print(String(dataPin));
+  Serial.print(dataPin);
+  Serial.print(" (");
+  Serial.print(itoa(dataPin, tbuf, 10));
+  Serial.print(")");
   Serial.println("...");
   mySDI12.begin();
   delay(500);  // allow things to settle