-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Julia 1.11 #1372
Support Julia 1.11 #1372
Conversation
vchuravy
commented
Mar 31, 2024
- Test against v1.11
- WIP: adapt to 1.11 changes
src/compiler/interpreter.jl
Outdated
|
||
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, world::UInt, mode::API.CDerivativeMode) | ||
@assert world <= Base.get_world_counter() | ||
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, world::UInt, mode::API.CDerivativeMode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, world::UInt, mode::API.CDerivativeMode) | |
function EnzymeInterpreter(cache::CodeCache, mt::Union{Nothing,Core.MethodTable}, | |
world::UInt, mode::API.CDerivativeMode) |
src/compiler/interpreter.jl
Outdated
return EnzymeInterpreter( | ||
cache, | ||
mt, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
return EnzymeInterpreter( | |
cache, | |
mt, | |
return EnzymeInterpreter(cache, | |
mt, |
This is definitely required, but the bigger issue is almost certainly adapting to the new pipeline changes. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
==========================================
+ Coverage 68.30% 71.45% +3.14%
==========================================
Files 30 30
Lines 11953 12045 +92
==========================================
+ Hits 8165 8607 +442
+ Misses 3788 3438 -350 ☔ View full report in Codecov by Sentry. |
Merging WIP, will continue in separate PRs |