Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Scratch at version 1 for package deps, (keep existing compat) #1515

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2024

This pull request sets the compat entry for the Scratch package to 1 for package deps.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@vchuravy vchuravy merged commit f74c137 into main Jun 6, 2024
4 of 5 checks passed
@vchuravy vchuravy deleted the compathelper/new_version/2024-06-06-19-49-52-713-03157258248 branch June 6, 2024 19:53
Copy link
Contributor Author

github-actions bot commented Jun 6, 2024

Benchmark Results

main e6d8cc7... main/e6d8cc7f4a1196...
basics/overhead 4.03 ± 0.001 ns 4.03 ± 0.91 ns 1
time_to_load 0.356 ± 0.0025 s 0.357 ± 0.0059 s 0.995

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant