Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gc error #2316

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix gc error #2316

merged 2 commits into from
Feb 21, 2025

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Feb 20, 2025

No description provided.

@wsmoses wsmoses requested a review from vchuravy February 20, 2025 20:55
@wsmoses
Copy link
Member Author

wsmoses commented Feb 20, 2025

I have

using Enzyme

Enzyme.Compiler.DumpPostOpt[] = true 

struct ObjPair{A, B}
	x::A
	y::B
end

function makesum(pair)
	return pair.x[1]
end

function f(x)
	obj = ObjPair(x, 3)
	r = Base.inferencebarrier(makesum)(obj)
	return r::Float64
end


sprint() do io
    Enzyme.Compiler.enzyme_code_llvm(io, f, Active, Tuple{Duplicated{Vector{Float64}}})
end

as some test code, but I'm not sure how to make this into a good check, if @vchuravy you have any ideas

Copy link
Contributor

Benchmark Results

main b980e7f... main/b980e7f66f1bd2...
basics/overhead 4.03 ± 0.01 ns 4.03 ± 0.001 ns 1
time_to_load 1.11 ± 0.0028 s 1.1 ± 0.008 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@wsmoses wsmoses merged commit 43654f9 into main Feb 21, 2025
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant