-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Enhance the Grid View #72
Comments
Maybe I do not understand your first point, but is this what you want? For this use the View -> Filter option. The selected PIDs and time range of this filter affect the Bitrate, Bar, Grid and PCR/PTS views. The second point would make it a completely different view. Now the width is flexible, and adapts to the window size. Then the width would be fixed, need to introduce scroll bars, etc. Also I do not understand why use "the timestamp of the first PUSI packet of the LINE"? What if there are no packets on that line where payload starts? Why not just the timestamp of the first packet of that line? |
Hi @EricBerendsen ,
Just that! 👍
I don't know about this! Nice! However, some comments about the "Filter option window":
After thinking more on it: Yes the idea is to create a new "fixed width table" based on a time scale for each line. And regarding the timestamp, you're right, the best is to print only the calculated PCR based time for the first packet on that line. Please, think about this idea. Perhaps quite complex to implement it, but it's a good idea... or not? |
Hi @EricBerendsen , Another different trouble: The "Show Adaptation Filed", "Show Payload Start" and "Show Error Indicator" visualization is not quite visible. I suggest to add another button to "reduce the colour of non-selected packets". The idea is: when you enable Show Payload Start, then all packets of the same pid without the PUSI flag will be painted with a lower colour. The objective is to increase the visibility of the selected packets. Do you agree with that? |
Considered it, but would have all kinds of edge cases when PIDs are share between services (like teletext, PCR). When services share a PID, removing the service would also remove the PCR for other services.
Just realized, this view is not for a single service, but for the whole stream. So using PCR values does not make sense. Could calculate a time from the start of the stream. I'll think about this one a bit more
Then packets with the same PID would have different colours, depending on adaptation field and/or Payload start. Bit confusing I think. If the markers are difficult to see select a different zoom level, so the boxes are larger. |
Hi @EricBerendsen ,
I have some suggestions for the Grid View:
The objective is to use this "view" to check more visualy if the muxing is done correctly.
I hope you want to consider this.
Thank you for this very good project.
The text was updated successfully, but these errors were encountered: