Ignore duplicate txns via LRU cache (#3821)

* Ignore duplicate txns via LRU cache

* cache just in combined

crates/hotshot/src/tasks/mod.rs

@@ -119,6 +119,7 @@ pub fn add_queue_len_task<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Vers
 }
 
 /// Add the network task to handle messages and publish events.
+#[allow(clippy::missing_panics_doc)]
 pub fn add_network_message_task<
     TYPES: NodeType,
     I: NodeImplementation<TYPES>,

crates/hotshot/src/traits/networking/combined_network.rs

@@ -462,11 +462,8 @@ impl<TYPES: NodeType> ConnectedNetwork<TYPES::SignatureKey> for CombinedNetworks
             // Calculate hash of the message
             let message_hash = calculate_hash_of(&message);
 
-            // Check if the hash is in the cache
-            if !self.message_cache.read().contains(&message_hash) {
-                // Add the hash to the cache
-                self.message_cache.write().put(message_hash, ());
-
+            // Check if the hash is in the cache and update the cache
+            if self.message_cache.write().put(message_hash, ()).is_none() {
                 break Ok(message);
             }
         }

crates/task-impls/Cargo.toml

@@ -29,6 +29,7 @@ hotshot-types = { path = "../types" }
 hotshot-builder-api = { path = "../builder-api" }
 jf-signature = { workspace = true }
 jf-vid = { workspace = true }
+lru.workspace = true
 rand = { workspace = true }
 serde = { workspace = true }
 sha2 = { workspace = true }

crates/types/src/constants.rs

@@ -21,7 +21,7 @@ pub const LOOK_AHEAD: u64 = 5;
 pub const KAD_DEFAULT_REPUB_INTERVAL_SEC: u64 = 28800;
 
 /// the number of messages to cache in the combined network
-pub const COMBINED_NETWORK_CACHE_SIZE: usize = 1000;
+pub const COMBINED_NETWORK_CACHE_SIZE: usize = 200_000;
 
 /// the number of messages to attempt to send over the primary network before switching to prefer the secondary network
 pub const COMBINED_NETWORK_MIN_PRIMARY_FAILURES: u64 = 5;