Ignore duplicate txns via LRU cache #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-maron
approved these changes
Nov 6, 2024
Comment on lines
-465
to
+466
| // Check if the hash is in the cache | ||
| if !self.message_cache.read().contains(&message_hash) { | ||
| // Add the hash to the cache | ||
| self.message_cache.write().put(message_hash, ()); | ||
|
|
||
| // Check if the hash is in the cache and update the cache | ||
| if self.message_cache.write().put(message_hash, ()).is_none() { |
There was a problem hiding this comment.
I haven't profiled this enough to have an opinion on which is faster in most cases, but I'm all for making it more succinct
There was a problem hiding this comment.
It's not really for speed, it's so that we update the cache on every duplicate message. So if a really old message that's still in the cache comes in we make sure it becomes the most recently used and doesn't fall out of cache.
There was a problem hiding this comment.
Ah right this does work better with LRU semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: