Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #3848

Merged
merged 5 commits into from
Nov 5, 2024
Merged

update dependencies #3848

merged 5 commits into from
Nov 5, 2024

Conversation

imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented Nov 5, 2024

The espresso-types crate within the sequencer repo is not compiling when used as a dependency by external crates, due to version mismatches in async-lock with downstream dependencies. Specifically, the hotshot crate and other dependencies are relying on an outdated version of async-lock. Also, running cargo update caused issues with compilation because of older rust-toolchain version.

This PR:

  • updates async-lock to v3
  • sets toolchain to 1.82 in rust-toolchain.toml.
  • Run cargo update to refresh the lockfile.

These changes enable hotshot to compile as a library for other external crates. This would also allow the espresso-types to be used in external crate after all the other downstream dependencies of espresso-types pointing to git tags are updated in a similar way

For EspressoSystems/espresso-sequencer#2256

@imabdulbasit imabdulbasit changed the title compile without lockfile update dependencies Nov 5, 2024
imabdulbasit and others added 3 commits November 5, 2024 16:40
The hash needs to be updated when updating the rust toolchain version
@imabdulbasit imabdulbasit merged commit 0164ac8 into main Nov 5, 2024
24 checks passed
@imabdulbasit imabdulbasit deleted the ab/compile-without-lockfile branch November 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants