Remove unused ValidateStateUpdate Event, Consolidate Shared state insertions #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls148
reviewed
Nov 8, 2024
| @@ -257,34 +256,23 @@ pub(crate) async fn update_shared_state< | |||
| // We will defer broadcast until all states are updated to avoid holding onto the lock during a network call. | |||
There was a problem hiding this comment.
Nit: comment doesn't seem valid now that we don't broadcast_event
pls148
reviewed
Nov 8, 2024
| @@ -203,10 +203,6 @@ pub enum HotShotEvent<TYPES: NodeType> { | |||
| /// Upgrade certificate has been sent to the network | |||
| UpgradeCertificateFormed(UpgradeCertificate<TYPES>), | |||
|
|
|||
| /* Consensus State Update Events */ | |||
There was a problem hiding this comment.
Should this comment be kept, as it applies to the following non-removed events as well?
There was a problem hiding this comment.
It should, I do delete in the next pr though
pls148
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
ValidatedStateUpdatedevent - nobody was listening for it anymoreupdate_saved_leafsandupdate_validate_statebecause in most cases they should be called together.update_da_viewfor the once case where we want to update the validate state map without a leaf yet.Overall this should make it harder to do the wrong thing and makes the code updating shared state easier to write
This PR does not:
Key places to review: