Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epoch to threshold functions to allow dynamically sized committees #3886

Closed
wants to merge 3 commits into from
Closed

Add epoch to threshold functions to allow dynamically sized committees #3886

wants to merge 3 commits into from

Conversation

pls148
Copy link
Contributor

@pls148 pls148 commented Nov 14, 2024 •
edited
Loading

Part of #3826

This PR:

  • Adds an epoch parameter to Threshold trait to allow for committees to be a size other than the whole committee
  • Fixes how StaticQuorumFilter calculated *_threshold to use the epoch parameter instead of hardcoding to committee_size/2
  • Includes commits from Add randomized Membership impls for testing #3863 - this should be merged after that PR merges!

This PR does not:

Key places to review:

CI

@pls148 pls148 requested a review from bfish713 as a code owner November 14, 2024 00:03
@pls148 pls148 marked this pull request as draft November 14, 2024 00:03
@pls148 pls148 force-pushed the ps/3826-threshold-epoch branch 3 times, most recently from 790aae7 to 1152578 Compare November 15, 2024 17:44
@pls148 pls148 marked this pull request as ready for review November 15, 2024 17:53
@pls148 pls148 requested review from lukaszrzasik and ss-es November 15, 2024 17:53
@pls148 pls148 force-pushed the ps/3826-threshold-epoch branch from 1152578 to 7844b3e Compare November 16, 2024 01:13
@pls148 pls148 force-pushed the ps/3826-threshold-epoch branch 2 times, most recently from 738296f to cd5eac6 Compare November 20, 2024 18:58
@pls148 pls148 requested a review from rob-maron November 20, 2024 18:59
@pls148 pls148 force-pushed the ps/3826-threshold-epoch branch from cd5eac6 to 8be316a Compare November 20, 2024 19:03
@pls148 pls148 closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@lukaszrzasik lukaszrzasik Awaiting requested review from lukaszrzasik

@ss-es ss-es Awaiting requested review from ss-es

@rob-maron rob-maron Awaiting requested review from rob-maron

Assignees

@QuentinI QuentinI

@lukeiannucci lukeiannucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pls148 @QuentinI @lukeiannucci