Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRB] - Add DRB functions #3890

Merged
merged 11 commits into from
Nov 19, 2024
Merged

[DRB] - Add DRB functions #3890

merged 11 commits into from
Nov 19, 2024

Conversation

shenkeyao
Copy link
Member

Closes #3855.

This PR:

  • Creates a new create for dynamic leader election and adds functions for:
    • DRB difficulty level,
    • DRB seed result, and
    • Leader election.

This PR does not:

  • Update existing code to call these functions.

@shenkeyao shenkeyao requested a review from bfish713 as a code owner November 14, 2024 22:39
ss-es
ss-es reviewed Nov 15, 2024
View reviewed changes
mrain
mrain approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ss-es
ss-es approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@ss-es ss-es left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me

@shenkeyao shenkeyao merged commit 28ce8ed into main Nov 19, 2024
15 checks passed
@shenkeyao shenkeyao deleted the keyao/drb-functions branch November 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrain mrain mrain approved these changes

@ss-es ss-es ss-es approved these changes

@rob-maron rob-maron Awaiting requested review from rob-maron

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

Assignees

@ss-es ss-es

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DRB] - Add DRB functions
3 participants
@shenkeyao @mrain @ss-es