fix prover service for docker demo #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
Sneh1999
approved these changes
Oct 9, 2024
sveitser
approved these changes
Oct 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prover service on the main branch crashes in the Docker demo due to a panic caused by failed validation of the light client proxy address. This issue does not occur in the native demo, where everything works as expected.
The issue arose because the contracts in the Docker demo were deployed to different addresses than those in the native demo due to one additional transaction—specifically, a transfer of ownership—which resulted in a different nonce.
This PR fixes it by passing the env variable :
ESPRESSO_SEQUENCER_ETH_MULTISIG_ADDRESSso that both native demo and docker demo deploy contracts at the addresses specified in .env file