CI: skip ARM build on PRs #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arm uses buildjet and costs money. There is relatively little utility in running it on every PR. If necessary it can be triggered explicitly via workflow dispatch.
|
So this skips the docker builds because that requires the ARM build. |
Not sure how to configure GHA to do require the optional build_arm job to not fail before building the docker images.
sveitser
commented
Oct 29, 2024
jbearer
reviewed
Oct 29, 2024
|
The graph looks promising on the latest PR: https://github.com/EspressoSystems/espresso-sequencer/actions/runs/11576703665 ... |
|
This seems to work as desired on PRs now. |
sveitser
requested review from
philippecamacho,
ImJeremyHe,
tbro and
imabdulbasit
as code owners
Ancient123
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arm build uses buildjet and costs money. There is relatively little utility in running it on every PR. If necessary it can be triggered explicitly via workflow dispatch.
It will build the docker images in PRs but only for x86. This way we would still catch most issues in the dockerfiles before merge to main, even though we aren't building them for arm.