Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WS provider URL #2264

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fix WS provider URL #2264

merged 2 commits into from
Nov 7, 2024

Conversation

sveitser
Copy link
Collaborator

@sveitser sveitser commented Nov 7, 2024

This caused calls to the L1 provider to fail.

  • Ignore .env for typos.
  • Log fee contract address during proxy check for easier debugging.

To test run just demo and in another terminal scripts/smoke-test-demo.

This caused calls to the L1 provider to fail.

- Ignore `.env` for typos.
- Log fee contract address during proxy check for easier debugging.
@tbro
Copy link
Contributor

tbro commented Nov 7, 2024

To me it looks like just demo runs the docker images w/ main tag ... the ones from the PR would have a different tag right? So I'm not sure of these test steps.

@sveitser
Copy link
Collaborator Author

sveitser commented Nov 7, 2024

@tbro for locally fixing it only the change in the .env file is needed, so using the main images is fine. I don't know if this PR fixes everything but at least it helps for running just demo locally, so I'll merge.

@sveitser sveitser merged commit 70f8139 into main Nov 7, 2024
16 of 17 checks passed
@sveitser sveitser deleted the ma/fix-docker-demo branch November 7, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants