Fix uint64 underflow in SequencerClient #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This underflow causes the fund-builder service to query for the block with block number max(uint64) when the demo is started and the current block height is still zero. To test run `just demo` locally and `scripts/smoke-test-demo` in another terminal. We should also add a regression tests for this, or run our demo with non-release build (enabled overflow checks).
sveitser
requested review from
philippecamacho,
ImJeremyHe,
jbearer,
tbro and
imabdulbasit
as code owners
imabdulbasit
approved these changes
Nov 8, 2024
sveitser
force-pushed
the
ma/fix-docker-demo
branch
from
b926708 to
558e2d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This underflow causes the fund-builder service to query for the block with block number max(uint64) when the demo is started and the current block height is still zero.
To test
and run
scripts/smoke-test-demoin another terminal.We should also add a regression tests for this, or run our demo with non-release build (enabled overflow checks).
Also increases the number of retries from 5 to 10, so we would retry for a total of 2 seconds instead of 1. I figured it doesn't hurt to fail a second later.