Use PeerConfig for stake table committees #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
force-pushed
the
ab/peerconfig
branch
from
33fa6b7 to
40b1d11
Compare
imabdulbasit
changed the title
imabdulbasit
commented
Feb 28, 2025
| .into_iter() | ||
| .map(|config| config.stake_table_entry) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| justify_qc | ||
| .is_valid_cert( |
There was a problem hiding this comment.
might be better to change this function signature to pass PeerConfig instead of StakeTableEntry but I'll leave it for now
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
imabdulbasit
requested review from
mrain,
bfish713,
lukaszrzasik,
ss-es and
pls148
mrain
reviewed
Feb 28, 2025
hotshot-types/src/traits/election.rs
Outdated
| @@ -31,56 +29,64 @@ pub trait Membership<TYPES: NodeType>: Debug + Send + Sync { | |||
| fn stake_table( | |||
| &self, | |||
| epoch: Option<TYPES::Epoch>, | |||
| ) -> Vec<<TYPES::SignatureKey as SignatureKey>::StakeTableEntry>; | |||
| ) -> Result<Vec<PeerConfig<TYPES::SignatureKey>>, Self::Error>; | |||
There was a problem hiding this comment.
Is it necessary to wrap these returns in Result? All the impls seem infallible and the uses simply do something like unwrap_or_default().
There was a problem hiding this comment.
This was part of tech-debt that we discussed on zulip few weeks ago. Basically, we wanted this to return Option or Result. I agree that this doesn't do much because of unwrap_or_default() but that requires more work.
imabdulbasit
force-pushed
the
ab/peerconfig
branch
from
31a0980 to
799da25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: