Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auction results calculation logic #2708

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

Implements auction results calculation logic

This PR:

  • Implements the auction results calculation logic in the marketplace-solver module
  • Adds proper bid selection based on highest bid amount for each namespace
  • Ensures each winning bid is only included once in the results
  • Maintains the existing reserve bids functionality
  • Reuses the permissionless implementation for the permissioned method

This PR does not:

  • Change the database schema or API interfaces
  • Modify the existing bid submission process
  • Add additional validation for permissioned auctions (left for future work)

Key places to review:

  • marketplace-solver/src/state.rs, calculate_auction_results_permissionless function
  • marketplace-solver/src/state.rs, calculate_auction_results_permissioned function

Things tested

  • Logic for selecting highest bids per namespace
  • Handling of empty bid collections
  • Proper inclusion of reserve bids in results

[x] Issue linked or PR description mentions why this change is necessary.
[x] PR description is clear enough for reviewers.
[x] Documentation for changes (additions) has been updated (added).
[x] If this is a draft it is marked as "draft".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant