Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move public config structs to types crate #2709

Merged
merged 4 commits into from
Mar 4, 2025
Merged

move public config structs to types crate #2709

merged 4 commits into from
Mar 4, 2025

Conversation

imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented Mar 4, 2025 •
edited
Loading

This PR moves the public HotShot config structs to the types crate. This is useful for other crates, such as the client or prover when calling config endpoint

@imabdulbasit imabdulbasit requested a review from alxiong March 4, 2025 00:49
alxiong
alxiong approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. as long as this is purely a cherry-pick from another PR that already got review from system team.

@imabdulbasit imabdulbasit enabled auto-merge (squash) March 4, 2025 01:05
@imabdulbasit imabdulbasit merged commit 9661930 into main Mar 4, 2025
40 of 41 checks passed
@imabdulbasit imabdulbasit deleted the ab/move-public-config-structs branch March 4, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxiong alxiong alxiong approved these changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imabdulbasit @alxiong