Updated MAUI bindings to use new Compiled Bindings introduced in .NET 9 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prathameshnarkhede
commented
Mar 21, 2025
prathameshnarkhede
commented
- This pull request updates the MAUI bindings in Toolkit to leverage the new Compiled Bindings feature introduced in .NET 9.
- The changes include replacing existing bindings with compiled bindings for improved performance and type safety.
| @@ -152,7 +152,7 @@ private static void Attachment_Tapped(object? sender, EventArgs e) | |||
| return parent as PopupViewer; | |||
| } | |||
|
|
|||
| private class AttachmentViewModel : System.ComponentModel.INotifyPropertyChanged | |||
| internal class AttachmentViewModel : System.ComponentModel.INotifyPropertyChanged | |||
There was a problem hiding this comment.
Had to make this internally accessible to make use of compiled binding.
dotMorten
requested changes
Mar 21, 2025
Removed CodeAnalysis Dynamic Dependencies
|
This PR is ready with corrected bindings. I made sure that bindings breakpoints are hit with correct datacontext. |
mstefarov
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.