Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MAUI bindings to use new Compiled Bindings introduced in .NET 9 #630

Open
wants to merge 4 commits into
base: v.next
Choose a base branch
from
Open

Updated MAUI bindings to use new Compiled Bindings introduced in .NET 9 #630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f63d7f
Updated MAUI bindings to use new Compiled Bindings introduced in .Net 9
prathameshnarkhede Mar 21, 2025
b2ca881
Correcting data bindings and tested the code.
prathameshnarkhede Mar 25, 2025
771357e
Remove unused directives and dependencies in FloorFilter
prathameshnarkhede Mar 25, 2025
fbbd201
Remove DynamicDependency attributes and update to correct bindings
prathameshnarkhede Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Samples/Toolkit.SampleApp.Maui/Samples/BookmarksViewSample.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ private void SetMapViewBinding_Click(object? sender, EventArgs e)
_viewContainer.Children.Add(MyMapView);
if (_viewContainer.Children.Contains(MySceneView))
_viewContainer.Children.Remove(MySceneView);
Binding geoviewBinding = new Binding();
geoviewBinding.Source = MyMapView;
BookmarksView.SetBinding(Esri.ArcGISRuntime.Toolkit.Maui.BookmarksView.GeoViewProperty, geoviewBinding);
BookmarksView.SetBinding(Esri.ArcGISRuntime.Toolkit.Maui.BookmarksView.GeoViewProperty, static (MapView mapView) => mapView, source: MyMapView);
}

// Note that the Web Scene Specification does not use bookmarks.
Expand All @@ -55,9 +53,7 @@ private void SetSceneViewBinding_Click(object? sender, EventArgs e)
_viewContainer.Children.Add(MySceneView);
if (_viewContainer.Children.Contains(MyMapView))
_viewContainer.Children.Remove(MyMapView);
Binding geoviewBinding = new Binding();
geoviewBinding.Source = MySceneView;
BookmarksView.SetBinding(Esri.ArcGISRuntime.Toolkit.Maui.BookmarksView.GeoViewProperty, geoviewBinding);
BookmarksView.SetBinding(Esri.ArcGISRuntime.Toolkit.Maui.BookmarksView.GeoViewProperty, static (SceneView sceneView) => sceneView, source: MySceneView);
}

private void SetDocumentOne_Click(object? sender, EventArgs e)
Expand Down
8 changes: 4 additions & 4 deletions src/Toolkit/Toolkit.Maui/FloorFilter/FloorFilter.DefaultTemplates.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static FloorFilter()
VerticalOptions = LayoutOptions.Fill,
InputTransparent = false,
};
textLabel.SetBinding(Label.TextProperty, "ShortName");
textLabel.SetBinding(Label.TextProperty, static (FloorLevel level) => level.ShortName);
containingGrid.Children.Add(textLabel);
return containingGrid;
});
Expand All @@ -73,7 +73,7 @@ static FloorFilter()
Margin = new Thickness(8),
HorizontalOptions = LayoutOptions.Fill
};
textLabel.SetBinding(Label.TextProperty, "Name");
textLabel.SetBinding(Label.TextProperty, static (FloorFacility facility) => facility.Name);
textLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb("#6e6e6e"), Color.FromArgb("#fff"));

containingGrid.Children.Add(textLabel);
Expand Down Expand Up @@ -111,7 +111,7 @@ static FloorFilter()
FontSize = 14,
};
titleLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb("#6e6e6e"), Color.FromArgb("#fff"));
titleLabel.SetBinding(Label.TextProperty, "Name");
titleLabel.SetBinding(Label.TextProperty, static (FloorFacility facility) => facility.Name);

Label subtitleLabel = new Label
{
Expand All @@ -120,7 +120,7 @@ static FloorFilter()
VerticalOptions = LayoutOptions.Start,
};
subtitleLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb("#2e2e2e"), Color.FromArgb("#aaa"));
subtitleLabel.SetBinding(Label.TextProperty, "Site.Name");
subtitleLabel.SetBinding(Label.TextProperty, static (FloorFacility facility) => facility.Site?.Name);
textStack.Children.Add(titleLabel);
textStack.Children.Add(subtitleLabel);
Grid.SetRow(titleLabel, 0);
Expand Down
4 changes: 2 additions & 2 deletions src/Toolkit/Toolkit.Maui/FloorFilter/FloorFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ protected override void OnApplyTemplate()
{
PART_LevelListView.ItemTemplate = LevelDataTemplate;
PART_LevelListView.BindingContext = this;
PART_LevelListView.SetBinding(CollectionView.ItemsSourceProperty, new Binding(nameof(DisplayLevels), BindingMode.OneWay));
PART_LevelListView.SetBinding(CollectionView.SelectedItemProperty, new Binding(nameof(SelectedLevel), BindingMode.TwoWay));
PART_LevelListView.SetBinding(CollectionView.ItemsSourceProperty, nameof(DisplayLevels), BindingMode.OneWay);
PART_LevelListView.SetBinding(CollectionView.SelectedItemProperty, static (FloorFilter filter) => filter.SelectedLevel, BindingMode.TwoWay);
}
}

Expand Down
8 changes: 4 additions & 4 deletions src/Toolkit/Toolkit.Maui/Legend/Legend.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,25 @@ static Legend()
s_DefaultLayerItemTemplate = new DataTemplate(() =>
{
var nameLabel = new Label { FontSize = 18, VerticalOptions = LayoutOptions.Center };
nameLabel.SetBinding(Label.TextProperty, $"{nameof(LegendEntry.Content)}.{nameof(Layer.Name)}");
nameLabel.SetBinding(Label.TextProperty, static (Layer layer) => layer.Name);
return nameLabel;
});

s_DefaultSublayerItemTemplate = new DataTemplate(() =>
{
var nameLabel = new Label { FontSize = 14, VerticalOptions = LayoutOptions.Center };
nameLabel.SetBinding(Label.TextProperty, $"{nameof(LegendEntry.Content)}.{nameof(ILayerContent.Name)}");
nameLabel.SetBinding(Label.TextProperty, static (ILayerContent content) => content.Name);
return nameLabel;
});

s_DefaultLegendInfoItemTemplate = new DataTemplate(() =>
{
StackLayout sl = new StackLayout() { Orientation = StackOrientation.Horizontal };
var symbol = new SymbolDisplay { WidthRequest = 40, HeightRequest = 40, VerticalOptions = LayoutOptions.Center, Margin = new Thickness(0, 0, 5, 0) };
symbol.SetBinding(SymbolDisplay.SymbolProperty, $"{nameof(LegendEntry.Content)}.{nameof(LegendInfo.Symbol)}");
symbol.SetBinding(SymbolDisplay.SymbolProperty, static (LegendInfo info) => info.Symbol);
sl.Children.Add(symbol);
var nameLabel = new Label { FontSize = 12, VerticalOptions = LayoutOptions.Center };
nameLabel.SetBinding(Label.TextProperty, $"{nameof(LegendEntry.Content)}.{nameof(LegendInfo.Name)}");
nameLabel.SetBinding(Label.TextProperty, static (LegendInfo info) => info.Name);
sl.Children.Add(nameLabel);
return sl;
});
Expand Down
6 changes: 3 additions & 3 deletions src/Toolkit/Toolkit.Maui/OverviewMap/OverviewMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ static OverviewMap()
IsAttributionTextVisible = false
};
ActivityIndicator activity = new ActivityIndicator();
activity.SetBinding(ActivityIndicator.IsRunningProperty, new Binding("Map.LoadStatus", converter: converter, converterParameter: "Loading", source : mapView));
activity.SetBinding(ActivityIndicator.IsRunningProperty, static (Map map) => map.LoadStatus, converter: converter, converterParameter: "Loading", source: mapView);
root.Add(activity);
Label label = new Label()
{
TextColor = Colors.Black, Text = "Map failed to load. Did you forget an API key?"
};
label.SetBinding(VisualElement.IsVisibleProperty, new Binding("Map.LoadStatus", converter: converter, converterParameter: "FailedToLoad", source: mapView));
label.SetBinding(VisualElement.IsVisibleProperty, static (Map map) => map.LoadStatus, converter: converter, converterParameter: "FailedToLoad", source: mapView);
root.Add(label);
mapView.SetBinding(VisualElement.IsVisibleProperty, new Binding("Map.LoadStatus", converter: converter, converterParameter: "Loaded", source: mapView));
mapView.SetBinding(VisualElement.IsVisibleProperty, static (Map map) => map.LoadStatus, converter: converter, converterParameter: "Loaded", source: mapView);
root.Add(mapView);
INameScope nameScope = new NameScope();
NameScope.SetNameScope(rootFrame, nameScope);
Expand Down
18 changes: 9 additions & 9 deletions src/Toolkit/Toolkit.Maui/SearchView/SearchView.Appearance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static SearchView()
containingGrid.SetAppThemeColor(Grid.BackgroundColorProperty, Color.FromArgb("#4e4e4e"), Color.FromArgb("#151515"));

Label textLabel = new Label();
textLabel.SetBinding(Label.TextProperty, "Key.DisplayName");
textLabel.SetBinding(Label.TextProperty, static (ISearchSource key) => key.DisplayName);
textLabel.Margin = new Thickness(4);
textLabel.TextColor = Colors.White;
textLabel.FontSize = 14;
Expand All @@ -79,21 +79,21 @@ static SearchView()
textStack.RowDefinitions.Add(new RowDefinition { Height = GridLength.Auto });

Image imageView = new Image();
imageView.SetBinding(Image.SourceProperty, nameof(SearchSuggestion.IsCollection), converter: CollectionIconConverter);
imageView.SetBinding(Image.SourceProperty, static (SearchSuggestion suggestion) => suggestion.IsCollection, converter: CollectionIconConverter);
imageView.WidthRequest = 16;
imageView.HeightRequest = 16;
imageView.Margin = new Thickness(4);
imageView.VerticalOptions = LayoutOptions.Center;

Label titleLabel = new Label();
titleLabel.SetBinding(Label.TextProperty, nameof(SearchSuggestion.DisplayTitle));
titleLabel.SetBinding(Label.TextProperty, static (SearchSuggestion suggestion) => suggestion.DisplayTitle);
titleLabel.VerticalOptions = LayoutOptions.End;
titleLabel.VerticalTextAlignment = TextAlignment.End;
titleLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb(FOREGROUND_LIGHT), Color.FromArgb(FOREGROUND_DARK));

Label subtitleLabel = new Label();
subtitleLabel.SetBinding(Label.TextProperty, nameof(SearchSuggestion.DisplaySubtitle));
subtitleLabel.SetBinding(Label.IsVisibleProperty, nameof(SearchSuggestion.DisplaySubtitle), converter: EmptyStringConverter);
subtitleLabel.SetBinding(Label.TextProperty, static (SearchSuggestion suggestion) => suggestion.DisplaySubtitle);
subtitleLabel.SetBinding(Label.IsVisibleProperty, static (SearchSuggestion suggestion) => suggestion.DisplaySubtitle, converter: EmptyStringConverter);
subtitleLabel.VerticalOptions = LayoutOptions.Start;
subtitleLabel.VerticalTextAlignment = TextAlignment.Start;
subtitleLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb(FOREGROUND_LIGHT), Color.FromArgb(FOREGROUND_DARK));
Expand Down Expand Up @@ -128,22 +128,22 @@ static SearchView()
textStack.RowDefinitions.Add(new RowDefinition { Height = GridLength.Auto });

Image imageView = new Image();
imageView.SetBinding(Image.SourceProperty, nameof(SearchResult.MarkerImageData), converter: ImageSourceConverter);
imageView.SetBinding(Image.SourceProperty, static (SearchResult result) => result.MarkerImageData, converter: ImageSourceConverter);
imageView.WidthRequest = 24;
imageView.HeightRequest = 24;
imageView.Margin = new Thickness(4);
imageView.VerticalOptions = LayoutOptions.Center;

Label titleLabel = new Label();
titleLabel.SetBinding(Label.TextProperty, nameof(SearchResult.DisplayTitle));
titleLabel.SetBinding(Label.TextProperty, static (SearchResult result) => result.DisplayTitle);
titleLabel.FontAttributes = FontAttributes.Bold;
titleLabel.VerticalOptions = LayoutOptions.End;
titleLabel.VerticalTextAlignment = TextAlignment.End;
titleLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb(FOREGROUND_LIGHT), Color.FromArgb(FOREGROUND_DARK));

Label subtitleLabel = new Label();
subtitleLabel.SetBinding(Label.TextProperty, nameof(SearchResult.DisplaySubtitle));
subtitleLabel.SetBinding(Label.IsVisibleProperty, nameof(SearchResult.DisplaySubtitle), converter: EmptyStringConverter);
subtitleLabel.SetBinding(Label.TextProperty, static (SearchResult result) => result.DisplaySubtitle);
subtitleLabel.SetBinding(Label.IsVisibleProperty, static (SearchResult result) => result.DisplaySubtitle, converter: EmptyStringConverter);
subtitleLabel.VerticalOptions = LayoutOptions.Start;
subtitleLabel.VerticalTextAlignment = TextAlignment.Start;
subtitleLabel.SetAppThemeColor(Label.TextColorProperty, Color.FromArgb(FOREGROUND_LIGHT), Color.FromArgb(FOREGROUND_DARK));
Expand Down
20 changes: 10 additions & 10 deletions src/Toolkit/Toolkit/UI/Controls/FeatureForm/AttachmentsFormElementView.Maui.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ static AttachmentsFormElementView()
private static object BuildDefaultTemplate()
{
var root = new VerticalStackLayout();
root.SetBinding(VerticalStackLayout.IsVisibleProperty, nameof(FormElement.IsVisible));
root.SetBinding(VerticalStackLayout.IsVisibleProperty, static (FormElement element) => element.IsVisible);

Grid header = new Grid();
header.ColumnDefinitions.Add(new ColumnDefinition(GridLength.Star));
Expand All @@ -68,13 +68,13 @@ private static object BuildDefaultTemplate()
header.RowDefinitions.Add(new RowDefinition(GridLength.Auto));

var label = new Label();
label.SetBinding(Label.TextProperty, new Binding("Element.Label", source: RelativeBindingSource.TemplatedParent));
label.SetBinding(View.IsVisibleProperty, new Binding("Element.Label", source: RelativeBindingSource.Self, converter: new EmptyStringToBoolConverter()));
label.SetBinding(Label.TextProperty, static (FormElement element) => element.Label, source: RelativeBindingSource.TemplatedParent);
label.SetBinding(View.IsVisibleProperty, static (FormElement element) => element.Label, source: RelativeBindingSource.Self, converter: new EmptyStringToBoolConverter());
label.Style = FeatureFormView.GetFeatureFormTitleStyle();
header.Children.Add(label);
label = new Label();
label.SetBinding(Label.TextProperty, new Binding("Element.Description", source: RelativeBindingSource.TemplatedParent));
label.SetBinding(Label.IsVisibleProperty, new Binding("Element.Description", source: RelativeBindingSource.Self, converter: new EmptyStringToBoolConverter()));
label.SetBinding(Label.TextProperty, static (FormElement element) => element.Description, source: RelativeBindingSource.TemplatedParent);
label.SetBinding(Label.IsVisibleProperty, static (FormElement element) => element.Description, source: RelativeBindingSource.Self, converter: new EmptyStringToBoolConverter());
label.Style = FeatureFormView.GetFeatureFormCaptionStyle();
Grid.SetRow(label, 1);
header.Children.Add(label);
Expand All @@ -95,7 +95,7 @@ private static object BuildDefaultTemplate()

Grid.SetColumn(addButton, 1);
Grid.SetRowSpan(addButton, 2);
addButton.SetBinding(VisualElement.IsVisibleProperty, new Binding("Element.IsEditable", source: RelativeBindingSource.TemplatedParent));
addButton.SetBinding(VisualElement.IsVisibleProperty, static (AttachmentsFormElement element) => element.IsEditable, source: RelativeBindingSource.TemplatedParent);
header.Children.Add(addButton);

root.Children.Add(header);
Expand All @@ -108,10 +108,10 @@ private static object BuildDefaultTemplate()
ItemTemplate = new DataTemplate(() =>
{
var view = new FormAttachmentView();
view.SetBinding(FormAttachmentView.AttachmentProperty, new Binding());
view.SetBinding(FormAttachmentView.ElementProperty, new Binding("Element", source: RelativeBindingSource.TemplatedParent));
view.SetBinding(FormAttachmentView.AttachmentProperty, static (FormAttachmentView view) => view.Attachment);
view.SetBinding(FormAttachmentView.ElementProperty, static (FormAttachmentView view) => view.Element, source: RelativeBindingSource.TemplatedParent);
view.SetAppThemeColor(FormAttachmentView.IconColorProperty, Colors.Black, Colors.White);
view.SetBinding(ToolTipProperties.TextProperty, new Binding("Attachment.Name"));
view.SetBinding(ToolTipProperties.TextProperty, static (FormAttachmentView view) => view.Attachment?.Name);
return view;
}),
#if IOS
Expand All @@ -121,7 +121,7 @@ private static object BuildDefaultTemplate()
MinimumHeightRequest = 75,
#endif
};
itemsView.SetBinding(CollectionView.ItemsSourceProperty, new Binding("Element.Attachments", source: RelativeBindingSource.TemplatedParent));
itemsView.SetBinding(CollectionView.ItemsSourceProperty, static (FormAttachmentView view) => view.Element?.Attachments, source: RelativeBindingSource.TemplatedParent);
root.Children.Add(itemsView);

INameScope nameScope = new NameScope();
Expand Down
4 changes: 2 additions & 2 deletions src/Toolkit/Toolkit/UI/Controls/FeatureForm/ComboboxFormInputView.Maui.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ static ComboBoxFormInputView()
private static object BuildDefaultTemplate()
{
Picker view = new Picker();
view.SetBinding(Picker.IsEnabledProperty, "Element.IsEditable");
view.ItemDisplayBinding = new Binding(nameof(CodedValue.Name));
view.SetBinding(Picker.IsEnabledProperty, static (FieldFormElement element) => element.IsEditable);
view.ItemDisplayBinding = Binding.Create(static (CodedValue codedValue) => codedValue.Name);
INameScope nameScope = new NameScope();
NameScope.SetNameScope(view, nameScope);
nameScope.RegisterName("Picker", view);
Expand Down
2 changes: 1 addition & 1 deletion src/Toolkit/Toolkit/UI/Controls/FeatureForm/FeatureFormElementTemplateSelector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static FeatureFormElementTemplateSelector()
{
var view = new FieldFormElementView() { Margin = new Thickness(0, 0, 0, 10) };
view.SetBinding(FieldFormElementView.ElementProperty, Binding.SelfPath);
view.SetBinding(FieldFormElementView.FeatureFormProperty, new Binding(nameof(FeatureFormView.FeatureForm), source: new RelativeBindingSource(RelativeBindingSourceMode.FindAncestor, typeof(FeatureFormView))));
view.SetBinding(FieldFormElementView.FeatureFormProperty, static (FeatureFormView view) => view.FeatureForm, source: new RelativeBindingSource(RelativeBindingSourceMode.FindAncestor, typeof(FeatureFormView)));
return view;
});
DefaultGroupElementTemplate = new DataTemplate(() =>
Expand Down
Loading