Augment reality to show hidden infrastructure #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
requested changes
Jun 13, 2025
There was a problem hiding this comment.
Sample works well, nice work @TADraeseke! Added some general feedback/questions:
samples/augment-reality-to-show-hidden-infrastructure/build.gradle.kts
Outdated
Show resolved
Hide resolved
...ava/com/esri/arcgismaps/sample/augmentrealitytoshowhiddeninfrastructure/screens/MapScreen.kt
Outdated
Show resolved
Hide resolved
...ava/com/esri/arcgismaps/sample/augmentrealitytoshowhiddeninfrastructure/screens/MapScreen.kt
Outdated
Show resolved
Hide resolved
...maps/sample/augmentrealitytoshowhiddeninfrastructure/components/AugmentedRealityViewModel.kt
Show resolved
Hide resolved
...m/esri/arcgismaps/sample/augmentrealitytoshowhiddeninfrastructure/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...m/esri/arcgismaps/sample/augmentrealitytoshowhiddeninfrastructure/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...arcgismaps/sample/augmentrealitytoshowhiddeninfrastructure/screens/AugmentedRealityScreen.kt
Show resolved
Hide resolved
...arcgismaps/sample/augmentrealitytoshowhiddeninfrastructure/screens/AugmentedRealityScreen.kt
Outdated
Show resolved
Hide resolved
shubham7109
changed the title
shubham7109
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Looks good to approve 👍 , thanks for adding the changes @TADraeseke! Two minor comments:
.../convention/src/main/java/com/esri/arcgismaps/kotlin/build_logic/convention/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
...ment-reality-to-show-hidden-infrastructure/augment-reality-to-show-hidden-infrastructure.png
Outdated
Show resolved
Hide resolved
|
Thanks @shubham7109 -- added screenshot and placeholder API key value in secrets file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample Augment reality to show hidden infrastructure in
Augmented realitycategory.Links and Data
Sample Epic:
runtime/kotlin/issues/ISSUE_NUMBERWhat To Review
README.mdandREADME.metadata.jsonfiles