feat(dropdown-item): enhance component's interactivity states #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
aPreciado88
added
the
pr ready for visual snapshots
jcfranco
reviewed
Mar 28, 2025
| @@ -4,8 +4,7 @@ | |||
| * These properties can be overridden using the component's tag as selector. | |||
| * | |||
| * @prop --calcite-dropdown-item-background-color-hover: Specifies the item's background color when hovered. | |||
| * @prop --calcite-dropdown-item-background-color-press: Specifies the item's background color when selected or active. | |||
| * @prop --calcite-dropdown-item-icon-color-hover: Specifies the item's icon selection color when hovered. | |||
There was a problem hiding this comment.
To avoid a breaking change, can we deprecate and remove at 4.0? The prop itself would be applied if set by developers, but we'd no longer have default styling for it. cc @ashetland
There was a problem hiding this comment.
I updated the PR with --calcite-dropdown-item-icon-color-hover now being deprecated.
aPreciado88
added
pr ready for visual snapshots
|
@ashetland @SkyeSeitz Can you please take a look? |
|
LGTM! |
…nent-interactivity-states
jcfranco
approved these changes
Apr 7, 2025
| @@ -5,7 +5,7 @@ | |||
| * | |||
| * @prop --calcite-dropdown-item-background-color-hover: Specifies the item's background color when hovered. | |||
| * @prop --calcite-dropdown-item-background-color-press: Specifies the item's background color when selected or active. | |||
| * @prop --calcite-dropdown-item-icon-color-hover: Specifies the item's icon selection color when hovered. | |||
| * @prop --calcite-dropdown-item-icon-color-hover: [Deprecated] Specifies the item's icon selection color when hovered. | |||
There was a problem hiding this comment.
Very nitpicky, but there's an extra space at the end.
…activity-states' of github.com:Esri/calcite-design-system into aPreciado88/10019-dropdown-item-enhance-component-interactivity-states
aPreciado88
added
skip visual snapshots
aPreciado88
deleted the
aPreciado88/10019-dropdown-item-enhance-component-interactivity-states
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10019
Summary
deprecate(dropdown-item): remove
--calcite-dropdown-item-icon-color-hovercss token.