feat(fab): add component tokens #11838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elijbet
changed the title
github-actions
bot
added
the
enhancement
Elijbet
added
the
pr ready for visual snapshots
anveshmekala
reviewed
Apr 1, 2025
| @apply shadow-2; | ||
| --calcite-fab-shadow-internal: 0 6px 20px -4px rgba(0, 0, 0, 0.1), 0 4px 12px -2px rgba(0, 0, 0, 0.08); | ||
| box-shadow: var(--calcite-fab-shadow, var(--calcite-fab-shadow-internal)); | ||
|
|
||
| &:hover { | ||
| @apply shadow-2-lg; |
There was a problem hiding this comment.
Q: can the user customize the shadow when hovered/active using --calcite-fab-shadow
There was a problem hiding this comment.
The shadow for hover and active is going away and designers advised not to add tokens for these in the time being.
driskull
requested changes
Apr 3, 2025
driskull
reviewed
Apr 3, 2025
Elijbet
added
skip visual snapshots
Elijbet
force-pushed
the
elijbet/7180-fab-design-tokens
branch
from
e8c39dc to
d8f8ff4
Compare
Elijbet
added
skip visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Adds the following tokens for
fabcomponent.--calcite-fab-background-color: Specifies the component's background color.--calcite-fab-border-color: Specifies the component's border color.--calcite-fab-corner-radius: Specifies the component's corner radius.--calcite-fab-text-color: Specifies the component's text color.--calcite-fab-loader-color: Specifies the component's loader color.--calcite-fab-shadow: Specifies the component's shadow.