Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(popover): fix casing inconsistency #11848

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Apr 2, 2025

Related Issue: #N/A

Summary

Fix casing inconsistency to ensure the header-container class is consistently applied and styled across the popover component.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Apr 2, 2025
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 2, 2025
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update respective CSS classes.

@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 3, 2025
@Elijbet Elijbet marked this pull request as ready for review April 3, 2025 19:42
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Elijbet Elijbet merged commit e79f2e0 into dev Apr 3, 2025
14 checks passed
@Elijbet Elijbet deleted the elijbet/casing-inconsistency branch April 3, 2025 19:43
@github-actions github-actions bot added this to the 2025-04-29 - Apr Milestone milestone Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants