Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tidy up build #11860

Merged
merged 16 commits into from
Apr 7, 2025
Merged

refactor: tidy up build #11860

merged 16 commits into from
Apr 7, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 4, 2025 •
edited
Loading

Related Issue: N/A

Summary

  • removes obsolete dictionary init arguments
  • simplifies a preprocessor (thanks, @benelan!)

matgalla and others added 14 commits April 1, 2025 22:23
@matgalla
Established initial Tokens Studio color themes
0419c1d
@matgalla
Split semantic color JSON into 2 files for light and dark
0ef29fa
@matgalla
Updated Tokens Studio themes for semantic dark mode colors
b74d50b
@matgalla
Updated light.json to only include semantic light mode values
088b5bf
@matgalla
Updated dark.json to only include semantic dark mode values
76f5195
@matgalla
Updated core size token's type from "size" to "sizing"
b06b91b
@matgalla
Updated semantic container-size token's type from "breakpoint" to "di…
91f5b8b 
…mension"
@matgalla
Updated semantic size token type from "size" to "sizing"
65a62dc
@matgalla
Updated semantic space token type from "space" to "spacing"
231ed5a
@matgalla
Created Tokens Studio themes for different token types
1ea418e
@matgalla
Fixed syntax error for semantic-colors-light tokens foreground-3 and …
099a526 
…foreground-hover
@jcfranco
Merge branch 'dev' into matgalla/optimize-for-tokens-studio
3b6f653
@jcfranco
update token build
bd83d5b
@jcfranco
refactor: remove obsolete dictionary init arguments
28baaba
@jcfranco jcfranco changed the title Established initial Tokens Studio color themes refactor: remove obsolete dictionary init arguments Apr 4, 2025
@jcfranco jcfranco mentioned this pull request Apr 7, 2025
Merged
6 tasks
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Apr 7, 2025
@jcfranco jcfranco changed the title refactor: remove obsolete dictionary init arguments refactor: tidy up build Apr 7, 2025
@jcfranco jcfranco changed the title refactor: tidy up build refactor: tidy up build files Apr 7, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Apr 7, 2025
@jcfranco jcfranco requested a review from benelan April 7, 2025 20:27
@jcfranco jcfranco changed the title refactor: tidy up build files refactor: tidy up build Apr 7, 2025
@jcfranco jcfranco marked this pull request as ready for review April 7, 2025 22:23
@jcfranco jcfranco requested a review from alisonailea as a code owner April 7, 2025 22:23
@jcfranco jcfranco requested a review from aPreciado88 April 7, 2025 22:23
aPreciado88
aPreciado88 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcfranco jcfranco merged commit 2ac90e9 into dev Apr 7, 2025
23 checks passed
@jcfranco jcfranco deleted the jcfranco/tidy-up-token-build branch April 7, 2025 22:42
@github-actions github-actions bot added this to the 2025-04-29 - Apr Milestone milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aPreciado88 aPreciado88 aPreciado88 approved these changes

@benelan benelan Awaiting requested review from benelan

@alisonailea alisonailea Awaiting requested review from alisonailea alisonailea is a code owner

Assignees

@jcfranco jcfranco

Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-04-29 - Apr Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @aPreciado88 @matgalla