test: set up vitest browser mode test environment #11877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
skip visual snapshots
jcfranco
requested review from
eriklharper,
driskull and
Elijbet
and removed request for
alisonailea
eriklharper
approved these changes
Apr 8, 2025
benelan
approved these changes
Apr 9, 2025
| "test": "concurrently \"npm:test:stable\" \"npm:test:experimental\"", | ||
| "test:stable": "STABLE_TESTS=true vitest run", | ||
| "test:experimental": "EXPERIMENTAL_TESTS=true vitest run --browser.headless", | ||
| "test:watch": "npm run test:watch:stable && npm run test:watch:experimental", |
There was a problem hiding this comment.
Did you confirm test:watch works? I don't think test:experimental will run because test:stable won't exit. You may need to use concurrently like the test script does.
There was a problem hiding this comment.
Used concurrently + passthrough options. One thing to note is that interactive watch mode won't work as before since both test runners might conflict when handling input. I've updated the contributing doc with this info.
|
Merging! @benelan LMK if there's any additional tweaks needed for the |
jcfranco
added a commit
that referenced
this pull request
Apr 10, 2025
**Related Issue:** N/A ## Summary Adds passthrough arg support to `test` script missed in #11877.
benelan
added a commit
that referenced
this pull request
Apr 15, 2025
**Related Issue:** #11877 ## Summary Make vitest default to the stable tests when the `EXPERIMENTAL_TESTS` environment variable is not set. Previously, `npx vitest` would not find any tests to run. This change fixes the test runner integrations provided by some IDEs (including neovim and vscode). NOTE: We can probably get rid of the `STABLE_TESTS` environment variable with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11268
Summary
Some of Lumina's testing utils and patterns (e.g.,
mount) depend or work best on Vitest's experimental browser mode, so this PR enables testing with it. This supports E2E and/or spec tests that would be simpler to write with this mode (e.g., #7060).Tests meant for this mode should use the following naming pattern:
<name>.browser.(spec|e2e).tsx?(see example).Note: Until browser mode is stable, continue using the usual E2E or spec tests unless a browser-mode test is specifically needed.