feat(accordion-item): enhance component's interactivity states #11935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
aPreciado88
added
the
pr ready for visual snapshots
|
@ashetland @SkyeSeitz Can you please take a look? |
|
This is looking great! I just discovered, though, that we didn't account for
I'll add that to the issue as well. |
aPreciado88
added
pr ready for visual snapshots
…ciado88/10016-accordion-item-enhance-component-interactivity-states
|
@ashetland @SkyeSeitz Could you please take a look at the latest snapshots? It looks like they're the usual false positives. |
driskull
approved these changes
Apr 15, 2025
| @@ -184,6 +191,7 @@ export class AccordionItem extends LitElement { | |||
| return; | |||
| } | |||
|
|
|||
| this.appearance = closestAccordionParent.appearance; | |||
There was a problem hiding this comment.
can you modify the accordion e2e test to check for this as well? This test:
it("inheritable props: `iconPosition`, `iconType`, `selectionMode`, and `scale` modified on the parent get passed into items", async () => {
| class={{ | ||
| [CSS.header]: true, | ||
| [CSS_UTILITY.rtl]: dir === "rtl", | ||
| [`header--${this.appearance}`]: true, |
There was a problem hiding this comment.
nitpick: it would be nice if these classes were in the CSS object so they could be used in an e2e test if needed.
Visual changes to Accordion interaction states look great! Snapshots were false positives. 🚀 |
aPreciado88
added
skip visual snapshots
|
@driskull I updated the PR with the requested changes 🚀 |
|
Looks good! |
…onent-interactivity-states
aPreciado88
deleted the
aPreciado88/10016-accordion-item-enhance-component-interactivity-states
branch
benelan
added a commit
that referenced
this pull request
Apr 17, 2025
…gis-deps * origin/dev: (31 commits) chore: add workflow manager to team issue templates (#11971) chore: release next feat(accordion-item): enhance component's interactivity states (#11935) chore: release next build(deps): update dependency lerna to v8.2.2 (#11948) feat(switch): enhance component's colors for a11y and usability (#11951) chore: release next ci: remove redundant test mode environment variable (#11958) fix(input-date-picker): allow clearing invalid date value (#11937) build: update browserslist db (#11946) feat(notice): add token for close icon and title text color (#11938) fix(list, block-group): fix drag handle events when lists or blocks are nested (#11816) chore: release next build(deps): update dependency vite to v5.4.18 (#11949) ci: default to stable tests when experimental mode is not set (#11957) fix(input-number): cancel arrow down event (#11956) refactor: tidy up (#11945) docs(checkbox): update icon color prop context (#11950) build(deps): bump node minor version (#11927) chore: release next ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10016
Summary
appearance="solid"::hoverstate background color to--calcite-color-foreground-2and does not change text colors.:activestate background color to--calcite-color-foreground-3and does not change text colors.appearance="transparent"::hoverstate background color to--calcite-color-transparent-hoverand does not change text colors.:activestate background color to--calcite-color-transparent-pressand does not change text colors.appearance="solid"andappearance="transparent"::hoverand:activestates do not change text colors.:focusdoes not change text weight or icon color.