Save PID permanently

Author: schmengler

Plugin/Cron/Model/SchedulePlugin.php

@@ -0,0 +1,17 @@
+<?php
+declare(strict_types=1);
+
+namespace EthanYehuda\CronjobManager\Plugin\Cron\Model;
+
+use Magento\Cron\Model\Schedule;
+
+class SchedulePlugin
+{
+    public function afterTryLockJob(Schedule $subject, bool $result)
+    {
+        if ($result) {
+            $subject->setData('pid', \getmypid());
+        }
+        return $result;
+    }
+}

Test/Integration/ProcessIdTest.php

@@ -29,19 +29,37 @@ public function testProcessIdSavedOnStart()
         $this->whenTryLockJob($schedule);
         $this->thenScheduleIsSavedWithPid($schedule, $pid);
     }
+    public function testProcessIdMaintainedAfterSuccesfulRun()
+    {
+        $this->givenPid($pid);
+        $this->givenPendingSchedule($schedule);
+        $this->whenTryLockJob($schedule);
+        $this->andScheduleSavedWithSuccess($schedule);
+        $this->thenScheduleIsSavedWithPid($schedule, $pid);
+    }
 
     private function givenPendingSchedule(&$schedule)
     {
+        /** @var Schedule $newSchedule */
+        $newSchedule = $this->objectManager->create(Schedule::class);
+        $newSchedule->setStatus(Schedule::STATUS_PENDING);
+        $newSchedule->setJobCode('test_job_code');
+        $newSchedule->save();
         /** @var Schedule $schedule */
         $schedule = $this->objectManager->create(Schedule::class);
-        $schedule->setStatus(Schedule::STATUS_PENDING);
-        $schedule->setJobCode('test_job_code');
-        $schedule->save();
+        $schedule->load($newSchedule->getId());
     }
 
     private function whenTryLockJob(Schedule $schedule)
     {
-        $schedule->tryLockJob();
+        $lock = $schedule->tryLockJob();
+        $this->assertTrue($lock, 'Precondition: tryLockJob() should be successful');
+    }
+
+    private function andScheduleSavedWithSuccess(Schedule $schedule)
+    {
+        $schedule->setStatus(Schedule::STATUS_SUCCESS);
+        $schedule->save();
     }
 
     private function thenScheduleIsSavedWithPid(Schedule $schedule, $pid)

etc/crontab/di.xml

@@ -3,6 +3,9 @@
     <type name="Magento\Cron\Observer\ProcessCronQueueObserver">
         <plugin name="ethanyehuda_cronjobmanager" type="EthanYehuda\CronjobManager\Plugin\Cron\Observer\ProcessCronQueueObserverPlugin" />
     </type>
+    <type name="Magento\Cron\Model\Schedule">
+        <plugin name="ethanyehuda_cronjobmanager" type="EthanYehuda\CronjobManager\Plugin\Cron\Model\SchedulePlugin" />
+    </type>
     <type name="Magento\Cron\Model\ResourceModel\Schedule">
         <plugin name="ethanyehuda_cronjobmanager" type="EthanYehuda\CronjobManager\Plugin\Cron\Model\ScheduleResourcePlugin" />
     </type>