Skip to content

Config: Store role names instead of IDs #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NMertsch opened this issue Jun 4, 2024 · 2 comments · Fixed by #213
Closed

Config: Store role names instead of IDs #118

NMertsch opened this issue Jun 4, 2024 · 2 comments · Fixed by #213
Assignees

Comments

@NMertsch
Copy link
Contributor

NMertsch commented Jun 4, 2024

Currently, the Discord role IDs have to be hard-coded in the config file. To make the same configuration usable on multiple servers (e.g. test, prod), let's instead hard-code the role names.

@NMertsch NMertsch self-assigned this Jun 4, 2024
@artcz
Copy link
Contributor

artcz commented Jun 5, 2024

I think last year we used the IDs because of their immutability (roles names can change, you can create a new one with the same name, and then different roles will be added to the user).

cc @Kislovskiy who might remember more details from last year about this.

Can I suggest that if the goal is to make it reusable between servers (incl. test/prod) to make it a configurable setting depending on the environment?

@NMertsch
Copy link
Contributor Author

Thank you for the context. I have the impression that (at least in this project) role names are far more stable than role IDs.

@NMertsch NMertsch removed their assignment Jun 22, 2024
@NMertsch NMertsch self-assigned this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants