Skip to content

Add close command for threads/posts #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2025
Merged

Add close command for threads/posts #19

merged 6 commits into from
Feb 8, 2025

Conversation

cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Feb 6, 2025

The command will close the thread (if on a text channel), and archive the post (if on a forum channel).

When in a forum channel, the command will look for a tag from that specific forum called 'done' (each tag will have different IDs depending on the forum) and apply to the post if found.

The bot will send a message notifying who closed it.

The command will close the thread (if on a text channel),
and archive the post (if on a forum channel).

When in a forum channel, the command will look for a tag
from that specific forum called 'done' (each tag will have
different IDs depending on the forum) and apply to the post
if found.

The bot will send a message notifying who closed it.
@cmaureir
Copy link
Collaborator Author

cmaureir commented Feb 6, 2025

close_command.mp4

Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Contributor

@artcz artcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! thanks for the code. Let's also add some test here: https://github.com/EuroPython/internal-bot/blob/main/intbot/tests/test_bot/test_main.py :)

@cmaureir
Copy link
Collaborator Author

cmaureir commented Feb 8, 2025

@artcz I "tried" to add a test case, but I'm not certain if I'm doing right :/ it will most probably fail, but let's see

@cmaureir
Copy link
Collaborator Author

cmaureir commented Feb 8, 2025

so should I hardcode the types instead of creating a real Thread/Message/Forum ?

@cmaureir
Copy link
Collaborator Author

cmaureir commented Feb 8, 2025

Now it works!
But I don't know how to test the case where a message is sent into a non-thread channel, and also if the post will have or not the added tag. Any ideas?

Copy link
Contributor

@artcz artcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmaureir cmaureir merged commit ab6e005 into main Feb 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants