-
Notifications
You must be signed in to change notification settings - Fork 64
Implement a redirection system with a mapping #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Preview available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an astro expert, and this seems better than what we have currently so LGTM :)
I would like us to figure out at some point how to do it server-side, but it might not be that easy in our setup, and definitely very low priority. Let's focus on other things first.
Thanks for putting it together :)
Thanks so much for working on this Ege! Being an egg to pretty much everything related to web, I don't understand the details of the code well enough, but do get the intention (which looks good to me) and the ep-preview looks good too. But I get "connection reset" when trying to preview locally (I use docker). Maybe I did something wrong, but I want to confirm the docker build still works if this gets merged. Also, might it be helpful to put a wee paragraph in the readme on how to update the redirect file? <3 |
Please consider to use Astro build in redirects. |
For some reason, I thought this didn't work in a static environment in the past. It looks promising, thank you! |
Redirections are now defined in
src/data/redirects.json
Closes #1012