Skip to content

Implement a redirection system with a mapping #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

egeakman
Copy link
Member

@egeakman egeakman commented Mar 9, 2025

Redirections are now defined in src/data/redirects.json

Closes #1012

@egeakman egeakman added the enhancement New feature or request label Mar 9, 2025
@egeakman egeakman requested review from artcz, cybit and hypha March 9, 2025 23:57
@egeakman egeakman self-assigned this Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

Preview available

Key Value
url https://redirection-mapping.ep-preview.click
last update 2025-03-11T21:33:27.772Z

Copy link
Contributor

@artcz artcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an astro expert, and this seems better than what we have currently so LGTM :)

I would like us to figure out at some point how to do it server-side, but it might not be that easy in our setup, and definitely very low priority. Let's focus on other things first.

Thanks for putting it together :)

@hypha
Copy link
Contributor

hypha commented Mar 15, 2025

Thanks so much for working on this Ege! Being an egg to pretty much everything related to web, I don't understand the details of the code well enough, but do get the intention (which looks good to me) and the ep-preview looks good too. But I get "connection reset" when trying to preview locally (I use docker). Maybe I did something wrong, but I want to confirm the docker build still works if this gets merged.

Also, might it be helpful to put a wee paragraph in the readme on how to update the redirect file? <3

@nikoshell
Copy link
Contributor

Please consider to use Astro build in redirects.
https://docs.astro.build/en/guides/routing/#redirects

@egeakman
Copy link
Member Author

Please consider to use Astro build in redirects. https://docs.astro.build/en/guides/routing/#redirects

For some reason, I thought this didn't work in a static environment in the past. It looks promising, thank you!

@egeakman egeakman closed this Mar 26, 2025
@egeakman egeakman deleted the redirection-mapping branch April 13, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up redirect mapping
4 participants