Skip to content

Fix build warnings and errors, imporove build process. #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ check:
pnpm run astro check

build:
# TODO: update this to just `pnpm build` after resolving the astro-check warnings
pnpm run astro build
pnpm build
# NOTE: also let's find a better way to do this :D
find ./dist/_astro/ -iname '*.jpg' -delete

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"date-fns": "^4.1.0",
"date-fns-tz": "^3.2.0",
"hastscript": "^9.0.0",
"pagefind": "^1.3.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"rehype-autolink-headings": "^7.1.0",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/components/header/header-actions.astro
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const IS_LIVE = false;
<script>
document.addEventListener("DOMContentLoaded", function () {
const searchContainer = document.querySelector(".pagefind-ui");
const searchClear = document.querySelector(".pagefind-ui__search-clear");
const searchInput = searchContainer?.querySelector("input");
let selectedIndex = -1;

Expand Down
2 changes: 1 addition & 1 deletion src/components/keynoters/keynoters.astro
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const placeholders = Math.max(0, 6 - keynoters.length);
{
new Array(placeholders)
.fill(null)
.map((_, index) => (
.map((_, _index) => (
<Keynoter
name=""
slug=""
Expand Down
1 change: 1 addition & 0 deletions src/components/logo/logo.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//@ts-nocheck
// TODO: LogoInverted needs to be adapted to the new logo
const LogoInverted = ({ className }: { className?: string }) => {
return (
Expand Down
7 changes: 6 additions & 1 deletion src/components/ticket-tiers/ticket-tiers.astro
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,19 @@ interface Props {
ticketShopLink: string;
}

interface Feature {
text: string;
icon?: string;
}

interface TicketTierProps {
title: string;
educationPrice: number | string;
personalPrice: number | string;
businessPrice: number | string;
lateBusinessPrice?: number | string;
latePersonalPrice?: number | string;
features: string[];
features: Feature[];
}

const tiers: TicketTierProps[] = [
Expand Down