Skip to content

Prose Picture style. #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

Prose Picture style. #1123

merged 3 commits into from
Apr 23, 2025

Conversation

nikoshell
Copy link
Contributor

No description provided.

@europython-society
Copy link
Member

europython-society commented Apr 7, 2025

Preview available

Key Value
url https://ep2025-image.ep-preview.click
last update 2025-04-23T07:57:58.729Z

Use Picture for pictures.
@nikoshell nikoshell marked this pull request as ready for review April 19, 2025 19:54
@nikoshell nikoshell requested a review from clytaemnestra April 19, 2025 19:55
@egeakman
Copy link
Member

@nikoshell thanks for the PR! Can you attach an example of what this PR changes? 🤗

I'm not sure where to look to see the change.

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikoshell, could you please describe what problem this PR is addressing? I looked through the changes but didn’t notice any functional differences. I assume it might be for non-functional reasons, but not sure which ones, so I'd like to understand the motivation better.

@nikoshell
Copy link
Contributor Author

image
image
Before and after.

@nikoshell
Copy link
Contributor Author

We apply global style for prose which is used in markdown pages.
This allows to apply unified style to all pages and define prose style in one place without local hacking on each page.

There is no drastic changes in look, just images will look better, and we will be able to clean up.

@nikoshell nikoshell merged commit 727580b into ep2025 Apr 23, 2025
3 checks passed
@nikoshell nikoshell deleted the ep2025-image branch April 23, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants