Skip to content

Possibility to add session to favorites. #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 27, 2025
Merged

Possibility to add session to favorites. #1245

merged 13 commits into from
May 27, 2025

Conversation

nikoshell
Copy link
Contributor

@nikoshell nikoshell commented May 19, 2025

We can mark sessions as favorite by opening session page and clicking on the heart.
Favorite talks will be visible on the schedule.

Favorite talks are persist per device.

PC:
image
image

Mobile:
image

@europython-society
Copy link
Member

europython-society commented May 19, 2025

Preview available

Key Value
url https://ep2025-ilikeit.ep-preview.click
last update 2025-05-27T11:03:27.142Z

@nikoshell
Copy link
Contributor Author

@egeakman @artcz @hypha Can you provide any feedback about this feature?

@egeakman
Copy link
Member

Hey! Thanks for this long awaited awesome PR! I'll try to have a look in a few days.

@hypha
Copy link
Contributor

hypha commented May 20, 2025

Thank you so so much, Marcin, for the wonderful feature! A few preliminary thoughts:

  1. When favouring a talk and returning to the schedule, I need to manually refresh the page to see the favourite status reflected. Is it possible to update the state in the schedule view without requiring a refresh?

  2. Would it be possible to add the ability to favourite talks directly from the schedule overview? Viewers can then immediately identify talks they're interested in without needing to open individual talk details.

  3. The favouring functionality only works for talks and not tutorials. Is this intentional, or should we extend it to cover all session types?

  4. Do you think it is useful to leave a note somewhere to to clarify that these favourites won't carry over to different sessions & devices? I’m happy to help draft or suggest wording if useful.

@nikoshell nikoshell requested a review from clytaemnestra May 21, 2025 07:26
@nikoshell
Copy link
Contributor Author

Thank you so so much, Marcin, for the wonderful feature! A few preliminary thoughts:

1. When favouring a talk and returning to the schedule, I need to manually refresh the page to see the favourite status reflected. Is it possible to update the state in the schedule view without requiring a refresh?

2. Would it be possible to add the ability to favourite talks directly from the schedule overview? Viewers can then immediately identify talks they're interested in without needing to open individual talk details.

3. The favouring functionality only works for talks and not tutorials. Is this intentional, or should we extend it to cover all session types?

4. Do you think it is useful to leave a note somewhere to to clarify that these favourites won't carry over to different sessions & devices? I’m happy to help draft or suggest wording if useful.
  1. It is how cache works, I will check if we can do something with that.
  2. No.
  3. It works for all sessions. What kind of session type is missed?
  4. We try to collect a feedback to understand the issues. We will provide additional notes about this feature.

Thank you for all comments.

@clytaemnestra
Copy link
Contributor

@hypha it works for tutorials as well for me

image

@hypha
Copy link
Contributor

hypha commented May 21, 2025

It works for all sessions. What kind of session type is missed?
@hypha it works for tutorials as well for me

@nikoshell @clytaemnestra, I was blind. Please ignore point 3. Apologies.

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM - I just had two small questions

@egeakman
Copy link
Member

I'll have some time to review this over the weekend. I don't want to hold this, but I would like to review it before merging it. So let's give it a few days if that's fine with everyone.

@clytaemnestra clytaemnestra added the DO-NOT-MERGE Not ready to be merged yet label May 23, 2025
@clytaemnestra clytaemnestra requested a review from egeakman May 25, 2025 11:05
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I really appreciate your work @nikoshell! One small thought: since we're not currently using Svelte elsewhere in the project, would you be open to rewriting this using Astro + vanilla JS or React? We've used React before, so the team might be more familiar with that stack, and sticking to Astro/JS would keep things simple. Introducing Svelte could require some extra knowledge + maintenance work for the team going forward. Totally understand if you had a reason for choosing it, I just wanted to bring it up in case a lighter option might work just as well here!

Also, I will try to implement these after June 3rd when I will have more availability:

  • Sync favorites without refreshing the page across tabs
  • Ability to favorite a session from the main schedule page (as @hypha mentioned)

@egeakman egeakman removed the DO-NOT-MERGE Not ready to be merged yet label May 26, 2025
@nikoshell nikoshell merged commit e964dcd into ep2025 May 27, 2025
6 checks passed
@nikoshell nikoshell deleted the ep2025-ilikeit branch May 27, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants