-
Notifications
You must be signed in to change notification settings - Fork 64
Possibility to add session to favorites. #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview available
|
Hey! Thanks for this long awaited awesome PR! I'll try to have a look in a few days. |
Thank you so so much, Marcin, for the wonderful feature! A few preliminary thoughts:
|
Thank you for all comments. |
@hypha it works for tutorials as well for me ![]() |
@nikoshell @clytaemnestra, I was blind. Please ignore point 3. Apologies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM - I just had two small questions
I'll have some time to review this over the weekend. I don't want to hold this, but I would like to review it before merging it. So let's give it a few days if that's fine with everyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I really appreciate your work @nikoshell! One small thought: since we're not currently using Svelte elsewhere in the project, would you be open to rewriting this using Astro + vanilla JS or React? We've used React before, so the team might be more familiar with that stack, and sticking to Astro/JS would keep things simple. Introducing Svelte could require some extra knowledge + maintenance work for the team going forward. Totally understand if you had a reason for choosing it, I just wanted to bring it up in case a lighter option might work just as well here!
Also, I will try to implement these after June 3rd when I will have more availability:
- Sync favorites without refreshing the page across tabs
- Ability to favorite a session from the main schedule page (as @hypha mentioned)
We can mark sessions as favorite by opening session page and clicking on the heart.
Favorite talks will be visible on the schedule.
Favorite talks are persist per device.
PC:


Mobile:
