-
Notifications
You must be signed in to change notification settings - Fork 64
Upgrade to tailwind4 #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to tailwind4 #1262
Conversation
Preview available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the migration after the conference. This version changed how tailwind handles the priority of the passed classes. So it's really hard for us to have a clear idea of what still works and what doesn't given the amount of content we have.
Multiple cleanups was done to make the migration. We also don't have huge amount of content, it's ~30 pages + ~3 template, most of the content is markdown styled with prose and typography plugin directly. |
I totally get the idea of not wanting to break things right before the conference, especially with the traffic we now have. But we’re in a really good spot right now: we’re merging stuff quickly, getting reviews fast, and things are moving. That’s why I’d actually not wait until after the conference. In my experience, once the conference is over, everyone kind of switches to vacation mode, and it gets way harder to find someone who has the time (or energy) to jump in and fix things. Right now, if something goes wrong, we can catch and fix it fast and that’s a big plus. I can set aside half an hour this weekend to click through all the pages and make sure we catch all bugs. |
If you believe we can keep the effects contained, let's go for it! Thanks for taking the work of checking the pages @clytaemnestra! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikoshell I went through all the pages and created a ticket summarizing the issues I found: #1264. Nothing major, all smaller issues.
If you’d prefer to address them in a separate PR, let me know; I can approve this one, and we can handle the rest later. Or if you’d rather include the fixes here, just ping me once it’s ready for another review. I only checked the UI for now; I haven’t checked the changelog and looked at the code yet, but I can go through it once everything’s finalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Close #1038