Skip to content

Clean up #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025
Merged

Clean up #1263

merged 2 commits into from
May 25, 2025

Conversation

nikoshell
Copy link
Contributor

@nikoshell nikoshell commented May 23, 2025

Clean up base on astro check warnings and errors, hardening ts config.

Fix logo
image

@nikoshell nikoshell requested a review from clytaemnestra May 23, 2025 11:47
@europython-society
Copy link
Member

europython-society commented May 23, 2025

Preview available

Key Value
url https://ep2025-cleanup4.ep-preview.click
last update 2025-05-23T12:14:39.695Z

@hugovk
Copy link
Contributor

hugovk commented May 24, 2025

Thanks for fixing the logo. On which OS/browser is it cut off? The existing one looks okay in the browsers I tried on macOS and Android. Here's macOS/Chrome:

image

@nikoshell
Copy link
Contributor Author

Bug was just on Firefox.

@hugovk
Copy link
Contributor

hugovk commented May 25, 2025

Which OS and Firefox version?

This is macOS with latest Firefox 138:

image

@nikoshell
Copy link
Contributor Author

Which OS and Firefox version?

This is macOS with latest Firefox 138:
image

I found it on Linux Firefox 138.0.4 (64-bit)
But then was checking svg code directly and I saw that viewport is smaller then objects that overflow.

I think this can be confirmed with Inkscape or online with https://jakearchibald.github.io/svgomg/

image

@nikoshell nikoshell merged commit 46b8e75 into ep2025 May 25, 2025
6 checks passed
@nikoshell nikoshell deleted the ep2025-cleanup4 branch May 25, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants